Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 945609

Summary: net-libs/webkit-gtk: drop warning about clang recommendation
Product: Gentoo Linux Reporter: Pacho Ramos <pacho>
Component: Current packagesAssignee: Gentoo Linux Gnome Desktop Team <gnome>
Status: RESOLVED FIXED    
Severity: normal CC: mjo, pacho, sam, toolchain
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Pacho Ramos gentoo-dev 2024-12-01 16:48:08 UTC
Hello,

I think this was introduced in 2.46.x bump:
                if ! tc-is-clang ; then
                        ewarn "Upstream recommends that Clang be used to compile WebkitGTK:"
                        ewarn "  https://webkitgtk.org/2024/10/04/webkitgtk-2.46.html"
                fi


Personally, I think we should drop it as the message is not really useful to the admins. For example, when I saw it, I didn't know if webkit-gtk was going to break with gcc (supposedly it is still supported), or if I should use clang only for webkit-gtk.

If we expect people to use clang for webkit-gtk, the ewarn message should point to a wiki page or similar to properly configure it I think.

Thanks a lot
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-12-01 16:52:45 UTC
I was considering filing the same thing ;)

It's really just Google being Google (the recommendation comes from Skia and... yeah). And if webkit-gtk is broken with GCC, I promise it will receive toolchain@'s attention promptly.
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-12-01 16:54:17 UTC
BTW, when I dug into this last for e.g. libreoffice, it turned out that the relevant bug had been fixed a long time ago in GCC.

Now, is it possible (and maybe even likely) that Skia is tuned for Clang and they bother to check what code is generated and so on? Yeah, of course, but in the absence of actual tangible bugs they can point to...

commit 326d52937573cf713dd070d23573b8deb5c9ede8
Author: Sam James <sam@gentoo.org>
Date:   Tue May 23 10:30:58 2023 +0100

    app-office/libreoffice: drop obsolete GCC Skia warning

    Bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92645
    Signed-off-by: Sam James <sam@gentoo.org>
Comment 3 Michael Orlitzky gentoo-dev 2024-12-02 14:13:07 UTC
I'm going to add v2.46.4 soon and can drop it. My reasoning was,

  * The notice on the webkit-gtk website is brand new, and they probably
    tested it before recommending clang.

  * There's some apple overlap between webkit and clang that I think makes
    it more likely that they know what they are talking about (they may have
    added some optimizations themselves).

  * There are GCC patches landing in Skia all the time, but no easy way
    to tell what version is bundled with webkit.
Comment 4 Larry the Git Cow gentoo-dev 2024-12-03 14:31:15 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bd4cc1006e5daefae52d3b9f272371d12f238d05

commit bd4cc1006e5daefae52d3b9f272371d12f238d05
Author:     Michael Orlitzky <mjo@gentoo.org>
AuthorDate: 2024-12-03 14:22:42 +0000
Commit:     Michael Orlitzky <mjo@gentoo.org>
CommitDate: 2024-12-03 14:30:47 +0000

    net-libs/webkit-gtk: update 2.46.3 -> 2.46.4
    
    Closes: https://bugs.gentoo.org/945609
    Signed-off-by: Michael Orlitzky <mjo@gentoo.org>

 net-libs/webkit-gtk/Manifest                                     | 2 +-
 ...bkit-gtk-2.46.3-r410.ebuild => webkit-gtk-2.46.4-r410.ebuild} | 9 +++------
 ...bkit-gtk-2.46.3-r600.ebuild => webkit-gtk-2.46.4-r600.ebuild} | 9 +++------
 .../{webkit-gtk-2.46.3.ebuild => webkit-gtk-2.46.4.ebuild}       | 9 +++------
 4 files changed, 10 insertions(+), 19 deletions(-)
Comment 5 Pacho Ramos gentoo-dev 2024-12-03 20:11:40 UTC
Thanks Michael!