Bug 945297

Summary:	net-analyzer/firewalk-5.0-r2 fails to compile: init.c:62:27: error: passing argument 2 of catch_sig from incompatible pointer type [-Wincompatible-pointer-types]
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Gentoo Netmon project <netmon>
Status:	RESOLVED FIXED
Severity:	normal	Keywords:	PullRequest
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/40165
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	880545
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2024-11-29 09:15:20 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: net-analyzer/firewalk-5.0-r2 fails to compile.
Discovered on: amd64 (internal ref: tinderbox_musl)
System: MUSL-SYSTEM (https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#MUSL)

Info about the issue:
https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#CF0003

Comment 1 Agostino Sarubbo gentoo-dev

2024-11-29 09:15:21 UTC

Created attachment 912587 [details]
build.log

build log and emerge --info

Comment 2 Larry the Git Cow gentoo-dev

2025-02-10 09:25:57 UTC

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3a0ab90bbc07e9fa96cbc48db857a48e2d3130ec

commit 3a0ab90bbc07e9fa96cbc48db857a48e2d3130ec
Author:     NHOrus <jy6x2b32pie9@yahoo.com>
AuthorDate: 2025-01-16 17:48:50 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2025-02-10 09:25:36 +0000

    net-analyzer/firewalk: update EAPI 7 -> 8, C23 porting
    
    Fixes wrong signature for signal-related functions, implicit decls
    in configure by autoreconfing, and unwanted calls to strip by patching
    makefile
    
    Bug: https://bugs.gentoo.org/731202
    Bug: https://bugs.gentoo.org/899922
    Bug: https://bugs.gentoo.org/945297
    Signed-off-by: NHOrus <jy6x2b32pie9@yahoo.com>
    Closes: https://github.com/gentoo/gentoo/pull/40165
    Signed-off-by: Sam James <sam@gentoo.org>

 .../firewalk/files/firewalk-5.0-signal.patch       | 36 +++++++++++++++++++
 net-analyzer/firewalk/firewalk-5.0-r3.ebuild       | 42 ++++++++++++++++++++++
 2 files changed, 78 insertions(+)