Bug 944747 – sci-libs/cfitsio-4.5.0 fails to compile: putcol.c:1229:24: error: expected identifier or ( before nullptr

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Agostino Sarubbo 2024-11-23 17:43:26 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sci-libs/cfitsio-4.4.1 fails to compile.
Discovered on: amd64 (internal ref: gcc15_tinderbox)
System: GCC-15-SYSTEM (https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#GCC-15)

Info about the issue:
https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#CF0014

[Comment 1 Agostino Sarubbo 2024-11-23 17:43:28 UTC]

Created attachment 911674 [details]
build.log

build log and emerge --info

[Comment 2 Agostino Sarubbo 2024-11-23 17:43:28 UTC]

Error(s) that match a know pattern in addition to what has been reported in the summary:


FAILED: CMakeFiles/cfitsio.dir/putcol.c.o 
/var/tmp/portage/sci-libs/cfitsio-4.4.1/work/cfitsio-4.4.1/putcol.c:1229:24: error: expected identifier or ‘(’ before ‘nullptr’

[Comment 3 Agostino Sarubbo 2024-12-02 08:43:22 UTC]

tinderbox_musl has reproduced this issue with version 4.5.0 - Updating summary.

[Comment 4 Larry the Git Cow 2025-03-10 01:37:49 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7ac36f22a5ee77e6516ba65ce6ef9dabb9825be1

commit 7ac36f22a5ee77e6516ba65ce6ef9dabb9825be1
Author:     NHOrus <[e-mail]>
AuthorDate: 2025-03-01 09:27:14 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2025-03-10 01:36:31 +0000

    sci-libs/cfitsio: port to C23
    
    Rename nullptr to ptr_to_null, as it points to null in string, not
    is pointer that is null.
    
    Closes: https://bugs.gentoo.org/943959
    Closes: https://bugs.gentoo.org/944747
    Signed-off-by: NHOrus <[e-mail]>
    Closes: https://github.com/gentoo/gentoo/pull/40826
    Signed-off-by: Sam James <[e-mail]>

 sci-libs/cfitsio/cfitsio-4.5.0-r1.ebuild           | 73 ++++++++++++++++++++++
 .../files/cfitsio-4.5.0-rename-nullptr.patch       | 51 +++++++++++++++
 2 files changed, 124 insertions(+)