Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 943199

Summary: gnome-extra/gnome-software-46.4 fails to build with sys-apps/fwupd-2.0.1
Product: Gentoo Linux Reporter: crabbed halo ablution <crabbedhaloablution>
Component: Current packagesAssignee: Gentoo Linux Gnome Desktop Team <gnome>
Status: UNCONFIRMED ---    
Severity: normal CC: crabbedhaloablution, harrisl, johnmh, proxy-maint, sourek.petr, steffen.weber, toralf
Priority: Normal Keywords: PATCH
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: gnome-extra:gnome-software-46.4:20241110-203704.log
FWUPD1.patch
FWUPD2.patch

Description crabbed halo ablution 2024-11-10 20:52:01 UTC
First error:
FAILED: plugins/fwupd/libgs_plugin_fwupd.so.p/gs-fwupd-app.c.o 
x86_64-pc-linux-gnu-gcc -Iplugins/fwupd/libgs_plugin_fwupd.so.p -Iplugins/fwupd -I../gnome-software-46.4/plugins/fwupd -I. -I../gnome-software-46.4 -Ilib -I../gnome-software-46.4/lib -I/usr/include/appstream -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/sysprof-6 -I/usr/lib64/libffi/include -I/usr/include/gio-unix-2.0 -I/usr/include/json-glib-1.0 -I/usr/include/libsoup-3.0 -I/usr/include/gtk-4.0 -I/usr/include/pango-1.0 -I/usr/include/fribidi -I/usr/include/harfbuzz -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/webp -I/usr/include/cairo -I/usr/include/libpng16 -I/usr/include/freetype2 -I/usr/include/pixman-1 -I/usr/include/graphene-1.0 -I/usr/lib64/graphene-1.0/include -I/usr/include/libxmlb-2 -I/usr/include/polkit-1 -I/usr/include/fwupd-3 -I/usr/include/libjcat-1 -I/usr/include/p11-kit-1 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -std=c11 -fstack-protector-strong -Waggregate-return -Warray-bounds -Wcast-align -Wclobbered -Wdeclaration-after-statement -Wempty-body -Wextra -Wformat=2 -Wformat-nonliteral -Wformat-security -Wformat-signedness -Wignored-qualifiers -Wimplicit-function-declaration -Werror=implicit-function-declaration -Winit-self -Winline -Wmaybe-uninitialized -Wmissing-declarations -Wmissing-format-attribute -Wmissing-include-dirs -Wmissing-noreturn -Wmissing-parameter-type -Wmissing-prototypes -Wnested-externs -Werror=nested-externs -Wno-missing-field-initializers -Wno-strict-aliasing -Wno-suggest-attribute=format -Wno-unused-parameter -Wold-style-definition -Woverride-init -Wpacked -Wpointer-arith -Wredundant-decls -Wreturn-type -Wshadow -Wsign-compare -Wstrict-aliasing -Wstrict-prototypes -Wswitch-default -Wtype-limits -Wundef -Wuninitialized -Wunused-but-set-variable -Wwrite-strings -D_XOPEN_SOURCE=700 -D_GNU_SOURCE -DI_KNOW_THE_GNOME_SOFTWARE_API_IS_SUBJECT_TO_CHANGE -march=native -mtune=native -ggdb -O2 -pipe -fPIC -pthread -mfpmath=sse -msse -msse2 '-DG_LOG_DOMAIN="GsPluginFwupd"' '-DLOCALPLUGINDIR="/var/tmp/portage/gnome-extra/gnome-software-46.4/work/gnome-software-46.4-build/plugins/fwupd"' -MD -MQ plugins/fwupd/libgs_plugin_fwupd.so.p/gs-fwupd-app.c.o -MF plugins/fwupd/libgs_plugin_fwupd.so.p/gs-fwupd-app.c.o.d -o plugins/fwupd/libgs_plugin_fwupd.so.p/gs-fwupd-app.c.o -c ../gnome-software-46.4/plugins/fwupd/gs-fwupd-app.c
../gnome-software-46.4/plugins/fwupd/gs-fwupd-app.c: In function ‘gs_fwupd_app_set_from_device’:
../gnome-software-46.4/plugins/fwupd/gs-fwupd-app.c:121:41: error: ‘FWUPD_DEVICE_FLAG_ONLY_OFFLINE’ undeclared (first use in this function); did you mean ‘FWUPD_DEVICE_FLAG_END_OF_LIFE’?
  121 |         if (fwupd_device_has_flag (dev, FWUPD_DEVICE_FLAG_ONLY_OFFLINE))
      |                                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                         FWUPD_DEVICE_FLAG_END_OF_LIFE


Reproducible: Always
Comment 1 crabbed halo ablution 2024-11-10 20:53:08 UTC
Created attachment 908408 [details]
gnome-extra:gnome-software-46.4:20241110-203704.log
Comment 2 crabbed halo ablution 2024-11-10 20:55:38 UTC
It probably needs some of the git patches since January referencing fwupd-2.0.0
https://gitlab.gnome.org/GNOME/gnome-software/-/commits/main/plugins/fwupd?ref_type=heads
Comment 3 Pacho Ramos gentoo-dev 2024-11-17 12:23:48 UTC
*** Bug 943286 has been marked as a duplicate of this bug. ***
Comment 4 Harris Landgarten 2024-11-17 12:46:16 UTC
note: gtk+ fails to build with the same error
Comment 5 Petr Šourek 2024-12-11 10:10:22 UTC
(In reply to crabbed halo ablution from comment #2)
> It probably needs some of the git patches since January referencing
> fwupd-2.0.0
> https://gitlab.gnome.org/GNOME/gnome-software/-/commits/main/plugins/
> fwupd?ref_type=heads

Thanks, downloaded the topmost 2 patches, put it into /etc/portage/patches directory and I can confim, that gnome-extra/gnome-software-46.4 now compiled correctly.

Adding those 2 patches, if you would like to merge them.
Comment 6 Petr Šourek 2024-12-11 10:12:08 UTC
Created attachment 913794 [details, diff]
FWUPD1.patch

Just wanted those 2 commits to be sorted, still rookie, don't know if I can merge them into 1 file.
Comment 7 Petr Šourek 2024-12-11 10:13:17 UTC
Created attachment 913795 [details, diff]
FWUPD2.patch
Comment 8 Harris Landgarten 2024-12-11 12:49:08 UTC
gnome-software built to completion with the two patches