Bug 942816 – [kde overlay] kde-apps/dolphin-9999 now requires kde-frameworks/kfilemetadata

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Duncan 2024-11-03 12:45:07 UTC]

Upstream dolphin fdf854bd81d9e42df2d8672d49a0b7fcdb7443a5 moved target_link_libraries KF6::FileMetaData out from under if(HAVE_BALOO) but did not change kfilemetadata's cmake optional status, so I filed upstream https://bugs.kde.org/show_bug.cgi?id=495620 reporting that and suggesting they either change it to required if that was deliberate, or fix the option, as the then-current state of having an option but breaking the build if the option was turned off was a bug.

That bug was resolved by making kfilemetadata required in:

commit af77a3f5a8240599c1c7e0d07a2a3a485ca1af02
Author:     Méven Car
AuthorDate: Thu Oct 31 10:36:15 2024 +0100
Commit:     Méven Car
CommitDate: Thu Oct 31 10:36:15 2024 +0100

CMakeLists: make KFileMetadata a required dependency


So now gentoo/kde needs to catch up and move dolphin's existing USE=semantic-desktop controlled kde-frameworks/kfilemetadata dep to required and delete the corresponding cmake_use_find_package line. (USE=semantic-desktop should remain in control of the two baloo-related options/deps.)  Since kfilemetadata's already a hard-dep for  kde-apps/ark and kde-plasma/plasma-browser-integration (and optional for gwenview with USE=semantic-desktop which I of course have off) many will already have it.

(And despite personally preferring the TUI-mode app-misc/mc for most file management and kde-apps/gwenview for image and video file management, leaving little for dolphin  here but it's kde integration, I still consider it worth keeping for that.  If they decide dolphin's going to hard-require baloo that's a different story, but so far that hasn't happened.)

[Comment 1 Duncan 2024-11-03 13:33:26 UTC]

I realized I hadn't pasted the config-phase error:

-- Configuring done (5.9s)
CMake Error at src/CMakeLists.txt:210 (target_link_libraries):
Target "dolphinprivate" links to:

KF6::FileMetaData

but the target was not found.  Possible reasons include:

* There is a typo in the target name.
* A find_package call is missing for an IMPORTED target.
* An ALIAS target is missing.



-- Generating done (0.5s)
CMake Warning:
Manually-specified variables were not used by the project:

CMAKE_DISABLE_FIND_PACKAGE_SeleniumWebDriverATSPI


CMake Generate step failed.  Build files cannot be regenerated correctly.
* ERROR: kde-apps/dolphin-9999::kde failed (configure phase):

[Comment 2 Larry the Git Cow 2024-11-04 22:25:32 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=db9193ec9b9003463608cd9e3a54b8cb80299288

commit db9193ec9b9003463608cd9e3a54b8cb80299288
Author:     Andreas Sturmlechner <[e-mail]>
AuthorDate: 2024-11-04 22:00:47 +0000
Commit:     Andreas Sturmlechner <[e-mail]>
CommitDate: 2024-11-04 22:00:47 +0000

    kde-apps/dolphin: Update dependencies, IUSE semantic-desktop
    
    Upstream commits:
    af77a3f5a8240599c1c7e0d07a2a3a485ca1af02
    fdf854bd81d9e42df2d8672d49a0b7fcdb7443a5
    
    Closes: https://bugs.gentoo.org/942816
    Signed-off-by: Andreas Sturmlechner <[e-mail]>

 kde-apps/dolphin/dolphin-9999.ebuild | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)