Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 941253

Summary: media-libs/libva-intel-driver is broken on wayland with >=libva-2.22
Product: Gentoo Linux Reporter: Luca Santarelli <luca.santarelli>
Component: Current packagesAssignee: VA-API Project <vaapi>
Status: CONFIRMED ---    
Severity: normal CC: luca.santarelli
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
URL: https://github.com/intel/intel-vaapi-driver/pull/566
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: Patch from upstream

Description Luca Santarelli 2024-10-10 22:52:57 UTC
Created attachment 905158 [details, diff]
Patch from upstream

Running vainfo on wayland on computer with a i915 gpu (libva-intel-driver) errors out (undefined symbol: wl_drm_interface) due to changes in libva-2.22. Bug has been solved upstream but there isn't a new version available.

Further information:
https://gitlab.archlinux.org/archlinux/packaging/packages/libva-intel-driver/-/issues/1

Upstream patch: https://github.com/intel/intel-vaapi-driver/commit/4206d0e15363d188f30f2f3dbcc212fef206fc1d

Using the specified commit as a user patch (/etc/portage/patches/...) restores functionality to vainfo (and relevant software, such as mpv).
Comment 1 Larry the Git Cow gentoo-dev 2024-10-21 22:53:21 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6797ccb9fb80f8099bee8cdde68344f99ed1ae86

commit 6797ccb9fb80f8099bee8cdde68344f99ed1ae86
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2024-10-21 22:52:29 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2024-10-21 22:52:58 +0000

    media-libs/libva-intel-driver: Add patch to fix wayland
    
    Closes: https://bugs.gentoo.org/941253
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 .../files/2.4.1-Make-wl_drm-optional.patch         | 52 ++++++++++++++++++++++
 ...4.ebuild => libva-intel-driver-2.4.1-r5.ebuild} |  4 ++
 2 files changed, 56 insertions(+)
Comment 2 Luca Santarelli 2024-10-26 08:54:25 UTC
I tried the new ebuild on two different systems (one is pristine, meaning I didn't have libva-intel-driver ever installed) and the patch does NOT get applied by portage. I can't understand why.

andromeda ~ # ebuild /var/db/repos/gentoo/media-libs/libva-intel-driver/libva-intel-driver-2.4.1-r5.ebuild configure
[...]
andromeda ~ # cat /var/tmp/portage/media-libs/libva-intel-driver-2.4.1-r5/work/intel-vaapi-driver-2.4.1/src/i965_output_wayland.c | grep strcmp
    if (strcmp(interface, "wl_drm") == 0) {

From the patch:
-    if (strcmp(interface, "wl_drm") == 0) {
+    if (strcmp(interface, "wl_drm") == 0 && wl_vtable->drm_interface) {

The file is present in the tree and the ebuild mentions it in the PATCHES variable, but it doesn't get applied.
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-10-26 09:04:32 UTC
The ebuild calls `eapply_user` instead of `default`.
Comment 4 Larry the Git Cow gentoo-dev 2024-10-26 20:17:42 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=991b3edf59fb3e1f56619c4855e50aa5b2ef205b

commit 991b3edf59fb3e1f56619c4855e50aa5b2ef205b
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2024-10-26 20:15:29 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2024-10-26 20:17:35 +0000

    media-libs/libva-intel-driver: Fix patch application
    
    Bug:  https://bugs.gentoo.org/941253
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 ...el-driver-2.4.1-r5.ebuild => libva-intel-driver-2.4.1-r6.ebuild} | 6 +++---
 media-libs/libva-intel-driver/libva-intel-driver-9999.ebuild        | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)