| Summary: | app-office/texstudio-4.8.4 builds for Qt5 despite requiring Qt6 | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Michelangelo Scopelliti <kernelpanic> |
| Component: | Current packages | Assignee: | TeX project <tex> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | flow, ionen, kernelpanic |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 936956 | ||
| Attachments: |
build log
force Qt6 build |
||
|
Description
Michelangelo Scopelliti
2024-10-04 08:41:31 UTC
ftr texstudio is (unfortunately) using Qt's recommended method[1] which does not care if the ebuild requests a specific version and will fallback to Qt5 if anything went wrong. It's supposed to try Qt6 first but I wonder sometimes if it's random, for me it seems to use Qt6 even if Qt5 is present though. In this scenario, the ebuild setting -DQT_VERSION_MAJOR=6 does nothing given find_package(QT NAMES Qt6 Qt5 ...) will overwrite it. Kinda ideal would be for upstream to use QT_VERSION_MAJOR if it's already set before trying automagic, but as a quick hack could delete the entire "find_package(QT NAMES..." line to enforce the ebuild's. Not to say it will necessarily build for you if Qt6 didn't work for some reason, but at least it'll abort and hopefully say why. [1] https://doc.qt.io/qt-6/cmake-qt5-and-qt6-compatibility.html#supporting-older-qt-5-versions (In reply to Ionen Wolkens from comment #1) > ftr texstudio is (unfortunately) using Qt's recommended method[1] which does > not care if the ebuild requests a specific version and will fallback to Qt5 > if anything went wrong. It's supposed to try Qt6 first but I wonder > sometimes if it's random, for me it seems to use Qt6 even if Qt5 is present > though. > > In this scenario, the ebuild setting -DQT_VERSION_MAJOR=6 does nothing given > find_package(QT NAMES Qt6 Qt5 ...) will overwrite it. > > Kinda ideal would be for upstream to use QT_VERSION_MAJOR if it's already > set before trying automagic, but as a quick hack could delete the entire > "find_package(QT NAMES..." line to enforce the ebuild's. > It didn't work for me, it still built dor Qt5 > Not to say it will necessarily build for you if Qt6 didn't work for some > reason, but at least it'll abort and hopefully say why. > > [1] > https://doc.qt.io/qt-6/cmake-qt5-and-qt6-compatibility.html#supporting-older- > qt-5-versions I was able to build against Qt6 by removing Qt5 from find_package(QT NAMES Qt6 Qt5 ...) a patch will follow. Created attachment 904899 [details, diff]
force Qt6 build
Odd, wonder if there's something looking for Qt *before* that statement and it may be what found Qt5? Otherwise it'd be impossible if the line was removed without something else to overwrite the ebuild's. Dropping "Qt5" would force it to look again and overwrite with that though. (In reply to Ionen Wolkens from comment #4) > Odd, wonder if there's something looking for Qt *before* that statement and > it may be what found Qt5? Otherwise it'd be impossible if the line was > removed without something else to overwrite the ebuild's. > > Dropping "Qt5" would force it to look again and overwrite with that though. ..but I really don't see anything, are you really sure you had removed the line? (In reply to Ionen Wolkens from comment #5) > (In reply to Ionen Wolkens from comment #4) > > Odd, wonder if there's something looking for Qt *before* that statement and > > it may be what found Qt5? Otherwise it'd be impossible if the line was > > removed without something else to overwrite the ebuild's. > > > > Dropping "Qt5" would force it to look again and overwrite with that though. > > ..but I really don't see anything, are you really sure you had removed the > line? Well, I was sure when I wrote that, now not so much... I'm not able to reproduce it. And removing the line effectively creates a Qt6 build. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e7ee697a31ec4b8d90421e3aafd6bc9649675633 commit e7ee697a31ec4b8d90421e3aafd6bc9649675633 Author: Florian Schmaus <flow@gentoo.org> AuthorDate: 2024-10-04 20:31:17 +0000 Commit: Florian Schmaus <flow@gentoo.org> CommitDate: 2024-10-04 20:32:16 +0000 app-office/texstudio: disable qt5 automagic Closes: https://bugs.gentoo.org/940747 Signed-off-by: Florian Schmaus <flow@gentoo.org> .../texstudio/{texstudio-4.8.4.ebuild => texstudio-4.8.4-r1.ebuild} | 3 +++ 1 file changed, 3 insertions(+) |
