Bug 940729

Summary:	>=www-client/chromium-129.0.6668.70 rust profiler sanity check is unreliable
Product:	Gentoo Linux	Reporter:	zin0 <z_i_n_o>
Component:	Current packages	Assignee:	Chromium Project <chromium>
Status:	RESOLVED FIXED
Severity:	normal	CC:	kangie, z_i_n_o
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	proposed sanity check fix forgotten eprefix added

Description zin0 2024-10-03 19:04:55 UTC

Starting with chromium 129.0.6668.70, a new sanity check was added to the ebuild in order to make sure that a rust compiler is beeing used that has been built with the 'profiler' use flag.

See: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6e7857db57a841f28066459ece787800f2a28f2a

In it's current form, the sanity check can create incorrect results because of the way 'rust_lib_path' is determined.

For example, on ppc64le the machine hardware name printed out by 'uname -m' is 'ppc64le' but the rust target is called 'powerpc64le'. As a result, the build process will always die even if we're using a rust compiler built with USE='profiler'.

Therefore, I'd like to propose using 'rustc --print target-libdir' to determine 'rust_lib_path'.

Reproducible: Always

Comment 1 zin0 2024-10-03 19:06:20 UTC

Created attachment 904873 [details, diff]
proposed sanity check fix

Comment 2 zin0 2024-10-03 20:44:36 UTC

Created attachment 904876 [details, diff]
forgotten eprefix added

Forgot to add the eprefix variable. Fixed now.

Comment 3 Matt Jolly gentoo-dev

2024-10-08 00:02:38 UTC

Thanks for the report; I'll apply during this week's bumps.

Comment 4 Larry the Git Cow gentoo-dev

2024-10-09 23:43:13 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8e8209db6d60ccc49174f67677861f8c05e8af6e

commit 8e8209db6d60ccc49174f67677861f8c05e8af6e
Author:     Matt Jolly <kangie@gentoo.org>
AuthorDate: 2024-10-09 23:12:29 +0000
Commit:     Matt Jolly <kangie@gentoo.org>
CommitDate: 2024-10-09 23:42:48 +0000

    www-client/chromium: make rust profiler sanity check more reliable
    
    On ppc64le the machine hardware name printed out by 'uname -m'
    is 'ppc64le' but the rust target is called 'powerpc64le'.
    As a result, the build process will always die even if
    we're using a rust compiler built with USE='profiler'.
    
    Use this opportunity to tighten up some language in the ebuild
    and elaborate more in comments.
    
    Closes: https://bugs.gentoo.org/940729
    Co-authored-by: zin0 <z_i_n_o@bluewin.ch>
    Signed-off-by: Matt Jolly <kangie@gentoo.org>

 www-client/chromium/chromium-129.0.6668.100.ebuild | 13 +++++++------
 www-client/chromium/chromium-130.0.6723.31.ebuild  | 13 +++++++------
 2 files changed, 14 insertions(+), 12 deletions(-)