Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 940253

Summary: dev-python/rpyc: reinvents every Python eclass variable/function possible
Product: Gentoo Linux Reporter: Michał Górny <mgorny>
Component: Current packagesAssignee: Andrey Grozin <grozin>
Status: CONFIRMED ---    
Severity: normal CC: grozin, python, qa
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 803152    

Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2024-09-26 04:44:58 UTC
The ebuild suffers from serious NIH:

> do PYTHONPATH="${WORKDIR}"/${P}-${EPYTHON/./_}/install/usr/lib/${EPYTHON}/site-packages ${EPYTHON} ${x} || die "${x} failed"

This is reinventing ${BUILD_DIR}, $(python_get_sitedir) (and both of them poorly), and on top of that, setting PYTHONPATH here should be completely unnecessary here since the eclass does that.
Comment 1 Andrey Grozin gentoo-dev 2025-04-29 14:41:58 UTC
(In reply to Michał Górny from comment #0)
> setting PYTHONPATH here should be completely
> unnecessary here since the eclass does that.
Without setting PYTHONPATH I get

Traceback (most recent call last):
  File "/var/tmp/portage/dev-python/rpyc-6.0.2/work/rpyc-6.0.2/tests/test_affinity.py", line 4, in <module>
    from tests import support
ModuleNotFoundError: No module named 'tests'