Bug 939195

Summary:	net-analyzer/wireshark: fails to open the release notes
Product:	Gentoo Linux	Reporter:	Holger Hoffstätte <holger>
Component:	Current packages	Assignee:	Sam James <sam>
Status:	RESOLVED FIXED
Severity:	normal	CC:	holger
Priority:	Normal	Keywords:	PullRequest
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/38495 https://gitlab.com/wireshark/wireshark/-/issues/20055 https://gitlab.com/wireshark/wireshark/-/merge_requests/17202
Whiteboard:
Package list:		Runtime testing required:	---

Description Holger Hoffstätte 2024-09-06 20:17:01 UTC

While trying to update wireshark to 4.4.0 I noticed that the Help->Release Notes link does not work, for multiple reasons:
- the release notes are not installed with USE=-doc (the default, due to an insane dependency chain)
- the code is wrong or we pass a wrong prefix into cmake, resulting in a wrong URL like file:///usr/usr/share/..

This seems to be the case for at least 4.2.6 & 4.4.0 (probably all versions).

The bug can be found in wsutil/filesystem.c:get_doc_dir() (https://gitlab.com/wireshark/wireshark/-/blob/master/wsutil/filesystem.c?ref_type=heads#L1117) where the install_prefix and DOC_DIR are concatenated at runtime.


Reproducible: Always

Steps to Reproduce:
1) emerge wireshark with USE=-doc (default)
2) Try to access Help -> Release Notes

Actual Results:  
Broken URL error

Expected Results:  
Release Notes are shown

Comment 1 Holger Hoffstätte 2024-09-09 12:39:35 UTC

As the linked upstream bug has explained, this is clearly a bug in our cmake.eclass which generates absolute values where it should not.

Comment 2 Holger Hoffstätte 2024-09-09 15:33:50 UTC

PR updated with patch from linked upstream MR, which fixes the problem.

Comment 3 Larry the Git Cow gentoo-dev

2024-10-05 07:22:40 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=690de938f65c99ed989b56877bd2c983bf6adec1

commit 690de938f65c99ed989b56877bd2c983bf6adec1
Author:     Holger Hoffstätte <holger@applied-asynchrony.com>
AuthorDate: 2024-09-27 15:42:37 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-10-05 07:22:05 +0000

    net-analyzer/wireshark: add 4.4.0, fix handling of release notes
    
    Closes: https://bugs.gentoo.org/939195
    
    Signed-off-by: Holger Hoffstätte <holger@applied-asynchrony.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 net-analyzer/wireshark/Manifest                    |   2 +
 net-analyzer/wireshark/files/release-notes.html    |   6 +
 ...shark-4.4.0-fix-filesystem-absolute-paths.patch |  98 ++++++
 net-analyzer/wireshark/wireshark-4.4.0.ebuild      | 362 +++++++++++++++++++++
 net-analyzer/wireshark/wireshark-9999.ebuild       |  20 +-
 5 files changed, 485 insertions(+), 3 deletions(-)