Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 93856

Summary: X.org 6.8.99.8 ebuild: duplicated if statement
Product: Gentoo Linux Reporter: Peter Gordon (RETIRED) <codergeek42>
Component: New packagesAssignee: Gentoo X packagers <x11>
Status: RESOLVED FIXED    
Severity: trivial    
Priority: High    
Version: 2005.0   
Hardware: x86   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Peter Gordon (RETIRED) gentoo-dev 2005-05-24 15:11:27 UTC
The x11-base/xorg-x11-6.8.99.8 ebuild contains the same if statement to workaround bug 77949. In the check_use_combos function the following exists twice: 
--- Begin: code snippet ---
check_use_combos() {

[...]

	# (#77949)
	if use minimal && use doc; then
		die "The minimal and doc USE flags are temporarily incompatible and result in a dead build."
	fi

	# (#77949)
	if use minimal && use doc; then
		die "The minimal and doc USE flags are temporarily incompatible and result in a dead build."
	fi

--- End: code snippet ---

This doesn't seem to hamper the build, but it does not make sense to me to have this checked for twice when it will die if the conditional is true the first time. A trivial matter though...
Comment 1 Donnie Berkholz (RETIRED) gentoo-dev 2005-05-24 15:50:08 UTC
Yeah, just got a bad paste in there from somewhere else, I think.

Fixed, thanks.