Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 937883

Summary: app-arch/libdeflate - enable gzip and zlib unconditionally
Product: Gentoo Linux Reporter: Mike Gilbert <floppym>
Component: Current packagesAssignee: Paul Zander <negril.nx+gentoo>
Status: RESOLVED FIXED    
Severity: normal CC: proxy-maint
Priority: Normal Keywords: PullRequest
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://bugs.gentoo.org/show_bug.cgi?id=937881
https://github.com/gentoo/gentoo/pull/38236
Whiteboard:
Package list:
Runtime testing required: ---

Description Mike Gilbert gentoo-dev 2024-08-13 20:52:49 UTC 
The libdeflate API varies depending on the gzip and zlib USE flags. This is a bad idea in general, and will lead to breakage if users toggle the USE flags off after installing reverse dependencies.

Please consider enabling gzip and zlib support unconditionally and dropping the USE flags. There do not appear to be any external dependencies to worry about, so the only benefit to making them optional is a small decrease in code size.
Comment 1 Larry the Git Cow gentoo-dev 2024-08-25 15:41:30 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d459cd74b963c1865c26b90cefe7701f4b72c5bb

commit d459cd74b963c1865c26b90cefe7701f4b72c5bb
Author:     Paul Zander <negril.nx+gentoo@gmail.com>
AuthorDate: 2024-08-14 15:19:04 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-08-25 15:39:58 +0000

    app-arch/libdeflate: enable gzip & zlib unconditionally
    
    Closes: https://bugs.gentoo.org/937883
    Signed-off-by: Paul Zander <negril.nx+gentoo@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 .../{libdeflate-1.19.ebuild => libdeflate-1.19-r1.ebuild}    | 12 ++++--------
 .../{libdeflate-1.20.ebuild => libdeflate-1.20-r1.ebuild}    | 12 ++++--------
 app-arch/libdeflate/libdeflate-9999.ebuild                   | 12 ++++--------
 app-arch/libdeflate/metadata.xml                             |  6 ++----
 dev-util/maxcso/maxcso-9999.ebuild                           |  2 +-
 .../{openexr-3.2.3.ebuild => openexr-3.2.3-r1.ebuild}        |  2 +-
 .../{openexr-3.2.4.ebuild => openexr-3.2.4-r1.ebuild}        |  2 +-
 7 files changed, 17 insertions(+), 31 deletions(-)
Comment 2 Larry the Git Cow gentoo-dev 2024-08-29 16:14:58 UTC 
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c5552fd1faac0ba4997cc0ed08fcc4d4930800fd

commit c5552fd1faac0ba4997cc0ed08fcc4d4930800fd
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2024-08-29 16:10:52 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2024-08-29 16:12:13 +0000

    media-libs/openexr: add [zlib(+)] to libdeflate
    
    Bug: https://bugs.gentoo.org/937883
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 .../openexr/{openexr-3.2.3-r1.ebuild => openexr-3.2.3-r2.ebuild}      | 4 ++--
 .../openexr/{openexr-3.2.4-r1.ebuild => openexr-3.2.4-r2.ebuild}      | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=24e98b6890889999ee78a49f84010fcf970f11f2

commit 24e98b6890889999ee78a49f84010fcf970f11f2
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2024-08-29 16:06:44 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2024-08-29 16:12:01 +0000

    dev-util/maxcso: add [zlib(+)] to libdeflate
    
    Bug: https://bugs.gentoo.org/937883
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 dev-util/maxcso/maxcso-9999.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)