Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 937626

Summary: x11-libs/gtksourceview-2.10.5-r3: fails to compile with gcc-14 (gtksourceview.c:1769:43: error: assignment to 'GtkSourceBuffer *' {aka 'struct _GtkSourceBuffer *'} from incompatible pointer type 'GtkTextBuffer *' {aka 'struct _GtkTextBuffer *'}
Product: Gentoo Linux Reporter: Holger Hoffstätte <holger>
Component: Current packagesAssignee: Gentoo Linux Gnome Desktop Team <gnome>
Status: RESOLVED FIXED    
Severity: normal CC: holger
Priority: Normal Keywords: PATCH, PullRequest
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://bugs.gentoo.org/show_bug.cgi?id=919080
https://github.com/gentoo/gentoo/pull/38579
Whiteboard: fixed in 2.10.5-r3
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 870412    
Attachments: Patch for 2.10.5

Description Holger Hoffstätte 2024-08-09 15:32:50 UTC
Same as #919080 which was fixed already:

gtksourceview.c: In function 'set_source_buffer':
gtksourceview.c:1769:43: error: assignment to 'GtkSourceBuffer *' {aka 'struct _GtkSourceBuffer *'} from incompatible pointer type 'GtkTextBuffer *' {aka 'struct _GtkTextBuffer *'} [-Wincompatible-pointer-types]
 1769 |                 view->priv->source_buffer = g_object_ref (buffer);
      |                                           ^



Reproducible: Always
Comment 1 Holger Hoffstätte 2024-08-09 15:34:00 UTC
Created attachment 899681 [details, diff]
Patch for 2.10.5
Comment 2 Agostino Sarubbo gentoo-dev 2024-09-12 12:57:45 UTC
gcc15_tinderbox has reproduced this issue with version 2.10.5-r3 - Updating summary.
Comment 3 Larry the Git Cow gentoo-dev 2024-09-15 12:25:18 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4f79cdcc9f9f1d131994a0764d0dc3e1d9a5fbad

commit 4f79cdcc9f9f1d131994a0764d0dc3e1d9a5fbad
Author:     Holger Hoffstätte <holger@applied-asynchrony.com>
AuthorDate: 2024-09-12 14:07:13 +0000
Commit:     Pacho Ramos <pacho@gentoo.org>
CommitDate: 2024-09-15 12:24:59 +0000

    x11-libs/gtksourceview: fix compilation of 2.10.5 with gcc-14
    
    Also use consistent patch names.
    
    Closes: https://bugs.gentoo.org/937626
    Signed-off-by: Holger Hoffstätte <holger@applied-asynchrony.com>
    Closes: https://github.com/gentoo/gentoo/pull/38579
    Signed-off-by: Pacho Ramos <pacho@gentoo.org>

 ...NST_RETURN.patch => 2.10.5-G_CONST_RETURN.patch} |  0
 x11-libs/gtksourceview/files/2.10.5-gcc14.patch     | 21 +++++++++++++++++++++
 .../gtksourceview/gtksourceview-2.10.5-r3.ebuild    |  5 ++++-
 3 files changed, 25 insertions(+), 1 deletion(-)