Bug 937492

Summary:	sys-fs/dd-rescue-1.99.13-r1 fails to compile: checksum_file.c:64:21: error: implicit declaration of function basename [-Wimplicit-function-declaration]
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Gentoo's Team for Core System packages <base-system>
Status:	RESOLVED FIXED
Severity:	normal	CC:	erhard_f
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	https://sourceforge.net/p/ddrescue/tickets/7/
See Also:	https://bugs.gentoo.org/show_bug.cgi?id=920159
Whiteboard:	musl/basename
Package list:		Runtime testing required:	---
Bug Depends on:	939440
Bug Blocks:	926147
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2024-08-07 07:33:26 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sys-fs/dd-rescue-1.99.13-r1 fails to compile.
Discovered on: amd64 (internal ref: tinderbox_musl)
System: MUSL-SYSTEM (https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#MUSL)

Info about the issue:
https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#CF0002

Comment 1 Agostino Sarubbo gentoo-dev

2024-08-07 07:33:27 UTC

Created attachment 899341 [details]
build.log

build log and emerge --info

Comment 2 Agostino Sarubbo gentoo-dev

2024-08-07 07:33:29 UTC

Error(s) that match a know pattern in addition to what has been reported in the summary:


fatal: not a git repository (or any parent up to mount point /var/tmp)
checksum_file.c:64:21: error: implicit declaration of function 'basename' [-Wimplicit-function-declaration[https://gcc.gnu.org/onlinedocs/gcc-14.2.0/gcc/Warning-Options.html#index-Wimplicit-function-declaration]]

Comment 3 ernsteiswuerfel archtester

2024-08-14 18:31:34 UTC

Opened an upstream ticket: https://sourceforge.net/p/ddrescue/tickets/7/

Comment 4 ernsteiswuerfel archtester

2024-08-20 19:45:27 UTC

Meanwhile upstream got the musl issues sorted out and latest DD_RESCUE_1_99_BRANCH git builds fine on musl-1.2.4 (and 1.2.5).

So with latest DD_RESCUE_1_99_BRANCH git the workaround is no longer needed.

Comment 5 Larry the Git Cow gentoo-dev

2024-12-27 16:52:55 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ec703e4ce5de46e4f427836d18988786190e5d2b

commit ec703e4ce5de46e4f427836d18988786190e5d2b
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-12-27 16:51:18 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-12-27 16:51:18 +0000

    sys-fs/dd-rescue: add 1.99.17
    
    * Update LICENSE to || ( GPL-2 GPL-3 ) per footer of website:
      "The program is protected by the GNU GPL (v2 or v3)."
      and output from the program.
    * Add USE=lzma for new support.
    * Ensure we respect flags for the testsuite.
    * Wire up more cpu_flags_x86_* flags.
    
    Closes: https://bugs.gentoo.org/920159
    Closes: https://bugs.gentoo.org/937492
    Closes: https://bugs.gentoo.org/939440
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-fs/dd-rescue/Manifest                 |   1 +
 sys-fs/dd-rescue/dd-rescue-1.99.17.ebuild | 125 ++++++++++++++++++++++++++++++
 2 files changed, 126 insertions(+)