Bug 937042

Summary:	[guru] sys-fs/fsverity-utils-1.6 installs '.a' files without static-libs USE
Product:	GURU	Reporter:	Agostino Sarubbo <ago>
Component:	Package issues	Assignee:	Mark Harmstone <mark>
Status:	RESOLVED FIXED
Severity:	normal	CC:	ceamac, guru-bugs, watermanpaint
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	785607
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2024-08-01 08:14:18 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sys-fs/fsverity-utils-1.6 installs '.a' files without static-libs USE.
Discovered on: amd64 (internal ref: guru_ci)

Info about the issue:
https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#QA0070

Comment 1 Agostino Sarubbo gentoo-dev

2024-08-01 08:14:19 UTC

Created attachment 898741 [details]
build.log

build log and emerge --info

Comment 2 Lucio Sauer 2024-08-01 10:13:40 UTC

Resolved in https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=7332d26856d9e7ee6d8b1499c309b84015dde686

Comment 3 Viorel Munteanu gentoo-dev

2024-08-01 10:20:43 UTC

The bug is fixed, but why do we need the static-libs flag?

https://projects.gentoo.org/qa/policy-guide/installed-files.html#pg0302

I don't see any dependency of sys-fs/fsverity-utils, static or otherwise.  I suggest dropping libfsverity.a and the USE flag.

Comment 4 Lucio Sauer 2024-08-01 10:46:03 UTC

(In reply to Viorel Munteanu from comment #3)
> The bug is fixed, but why do we need the static-libs flag?
> 
> https://projects.gentoo.org/qa/policy-guide/installed-files.html#pg0302
> 
> I don't see any dependency of sys-fs/fsverity-utils, static or otherwise.  I
> suggest dropping libfsverity.a and the USE flag.

I didn't read the Policy Guide closely enough. I'll provide a fix presently.

Comment 5 Larry the Git Cow gentoo-dev

2024-08-01 13:51:56 UTC

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=6a9edcb8dea89f3b77d71e42583e19072701b3f1

commit 6a9edcb8dea89f3b77d71e42583e19072701b3f1
Author:     Lucio Sauer <watermanpaint@posteo.net>
AuthorDate: 2024-08-01 12:51:15 +0000
Commit:     Lucio Sauer <watermanpaint@posteo.net>
CommitDate: 2024-08-01 13:00:45 +0000

    sys-fs/fsverity-utils: drop libfsverity.a (PG 0302)
    
    No revdeps and not required by this package except for testing, when
    USE_SHARED_LIB is set.  Export prefixed AR due to dependence on
    libfsverity.a at test phase.
    
    Bug: https://bugs.gentoo.org/937042
    Signed-off-by: Lucio Sauer <watermanpaint@posteo.net>

 sys-fs/fsverity-utils/fsverity-utils-1.6.ebuild | 22 +++++++++++++---------
 1 file changed, 13 insertions(+), 9 deletions(-)