Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 936072

Summary: www-client/firefox: possible to add LLVM 18 / newer Rust support to ESR?
Product: Gentoo Linux Reporter: Sam James <sam>
Component: Current packagesAssignee: Mozilla Gentoo Team <mozilla>
Status: RESOLVED FIXED    
Severity: normal CC: herrtimson, llvm, rust
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://bugs.gentoo.org/show_bug.cgi?id=936071
Whiteboard:
Package list:
Runtime testing required: ---

Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-07-15 00:04:58 UTC
We're about to stable LLVM 18 and things get easier if we're able to have Firefox supporting it in stable too to avoid a Rust mess.

Is it possible to backport the LLVM 18 / new Rust support?
Comment 1 Joonas Niilola gentoo-dev 2024-07-15 06:18:16 UTC
*sigh* I've been avoiding it. Haven't found a _simple_ patch touching only 1-2 crates to fix it, but instead the upstream "patch" to updating crates for rust-1.78 is 23,000 lines long. And of course that doesn't apply cleanly to ESR.

There's this though:
https://cgit.freebsd.org/ports/commit/www/firefox-esr?id=cc6466e821dd5655bbc18ffd61d3527228a94015
(but the complete series to make llvm-18 work includes 5 commits, 
https://cgit.freebsd.org/ports/log/www/firefox-esr)

I could try that though.

What a timing again. 128ESR is out, but I only plan to stabilize 128.2.0+ and that's out in September.
Comment 2 Joonas Niilola gentoo-dev 2024-07-15 12:38:55 UTC
Current:
20K     /var/cache/distfiles/firefox-115esr-patches-09.tar.xz

with rust-1.78 / llvm-18 patches:
52K     firefox-115esr-patches-11.tar.xz

... :D

Anyway, 
 * Package:    www-client/firefox-115.13.0:esr
 * Repository: gentoo
 * Maintainer: mozilla@gentoo.org
 * USE:        X abi_x86_64 amd64 clang dbus elibc_glibc gmp-autoupdate kernel_linux l10n_fi l10n_sv system-av1 system-harfbuzz system-icu system-jpeg system-libevent system-libvpx system-webp
 * FEATURES:   network-sandbox preserve-libs sandbox userpriv usersandbox
 * Checking for at least 6400 MiB disk space at "/var/tmp/portage/www-client/firefox-115.13.0/temp" ...
 * Using LLVM slot 18 to build

...

>>> Emerging (1 of 1) www-client/firefox-115.13.0::gentoo
>>> Installing (1 of 1) www-client/firefox-115.13.0::gentoo
>>> Completed (1 of 1) www-client/firefox-115.13.0::gentoo


I'll test that the new patchset doesn't _break_ current stable with llvm-17. And Thunderbird, of course.
Comment 3 Larry the Git Cow gentoo-dev 2024-07-15 13:07:52 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=98db1d579a983d860d6233db5968a19ddc073565

commit 98db1d579a983d860d6233db5968a19ddc073565
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2024-07-15 13:07:07 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2024-07-15 13:07:07 +0000

    mail-client/thunderbird: enable llvm-18/rust-1.78+
    
    Closes: https://bugs.gentoo.org/936072
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 mail-client/thunderbird/Manifest                    |  2 +-
 mail-client/thunderbird/thunderbird-115.12.1.ebuild | 17 +++++++++++++++--
 2 files changed, 16 insertions(+), 3 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=897270e689e9934a15978cee6cfbaaa02e406f8e

commit 897270e689e9934a15978cee6cfbaaa02e406f8e
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2024-07-15 13:06:09 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2024-07-15 13:06:09 +0000

    www-client/firefox: enable llvm-18/rust-1.78+ on 115esr
    
    Bug: https://bugs.gentoo.org/936072
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 www-client/firefox/Manifest                |  2 +-
 www-client/firefox/firefox-115.13.0.ebuild | 17 +++++++++++++++--
 2 files changed, 16 insertions(+), 3 deletions(-)
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-07-15 13:08:53 UTC
*Very* much appreciated, thank you.
Comment 5 Larry the Git Cow gentoo-dev 2024-07-17 07:24:49 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f8cf5f8a4da0bfef2c1840490ee9a3abea69096b

commit f8cf5f8a4da0bfef2c1840490ee9a3abea69096b
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2024-07-17 07:24:21 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2024-07-17 07:24:45 +0000

    mail-client/thunderbird: add 115.13.0
    
    Bug: https://bugs.gentoo.org/936072
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 mail-client/thunderbird/Manifest                   |   65 +
 .../thunderbird/thunderbird-115.13.0.ebuild        | 1363 ++++++++++++++++++++
 2 files changed, 1428 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0370bca0ccce6f8b1a04b494df76df4d072fdf3f

commit 0370bca0ccce6f8b1a04b494df76df4d072fdf3f
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2024-07-17 07:05:16 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2024-07-17 07:24:45 +0000

    mail-client/thunderbird: adjust rust dep with gcc or musl
    
    Bug: https://bugs.gentoo.org/936072
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 mail-client/thunderbird/thunderbird-115.12.1.ebuild | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0690a788fe9884a6bbf2ee65e56cbc30c9ab6198

commit 0690a788fe9884a6bbf2ee65e56cbc30c9ab6198
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2024-07-17 07:03:59 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2024-07-17 07:24:45 +0000

    www-client/firefox: adjust rust dep on 115esr with gcc or musl
    
    Bug: https://bugs.gentoo.org/936072
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 www-client/firefox/firefox-115.13.0.ebuild | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)