| Summary: | gui-wm/hyprland-0.41.2[-X] - [perl-5.40] [icu-75.1] [gcc-15] ../.../XWayland.hpp: error: HYPRATOM was not declared in this scope | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Toralf Förster <toralf> |
| Component: | Current packages | Assignee: | Julien Roy <julien> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bivsk, gibgibon, Gordi.Oleg, johnmh, jprentice, julien, parona, proxy-maint, sozuba |
| Priority: | Normal | Keywords: | PullRequest |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: |
https://github.com/hyprwm/Hyprland/pull/7538 https://github.com/gentoo/gentoo/pull/39404 https://bugs.gentoo.org/show_bug.cgi?id=945974 |
||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | 945974 | ||
| Bug Blocks: | |||
| Attachments: |
emerge-info.txt
emerge-history.txt.xz environment etc.clang.tar.xz etc.portage.tar.xz gui-wm:hyprland-0.41.2:20240702-010707.log.xz qlist-info.txt.xz temp.tar.xz |
||
Created attachment 896757 [details]
emerge-info.txt
Created attachment 896758 [details]
emerge-history.txt.xz
Created attachment 896759 [details]
environment
Created attachment 896760 [details]
etc.clang.tar.xz
Created attachment 896761 [details]
etc.portage.tar.xz
Created attachment 896762 [details]
gui-wm:hyprland-0.41.2:20240702-010707.log.xz
Created attachment 896763 [details]
qlist-info.txt.xz
Created attachment 896764 [details]
temp.tar.xz
https://github.com/hyprwm/Hyprland/commit/fa022901cf2c9acdae9e9a24a68b9148d44f8627 https://github.com/hyprwm/Hyprland/pull/6620#issuecomment-2183336876 Previously this was declared in the file now its supposed come from src/xwayland/XWM.hpp -> src/macros.hpp, which is guarded by NO_XWAYLAND leading to build failure when its built with -X. The fact that xwayland bits are compiled with -X is not unexpected behavior. https://github.com/hyprwm/Hyprland/issues/178#issuecomment-1152140205 This doesn't happen with gui-wm/hyprland-0.43.0 Is there any `0.42.0-r2` coming? 0.43 can't be compiled with gcc-13.3 for some reason. ``` * ERROR: gui-wm/hyprland-0.43.0::gentoo failed (setup phase): * GCC version is too old to compile Hyprland! ``` (In reply to Gordienko Oleg from comment #11) > Is there any `0.42.0-r2` coming? 0.43 can't be compiled with gcc-13.3 for > some reason. IIRC the maintainer is away on holiday. > ``` > * ERROR: gui-wm/hyprland-0.43.0::gentoo failed (setup phase): > * GCC version is too old to compile Hyprland! > ``` I don't think a new version is likely to fix that. hyprland AFAIK moved to even more experimental C++ requirements recently. (In reply to Gordio from comment #11) > Is there any `0.42.0-r2` coming? 0.43 can't be compiled with gcc-13.3 for > some reason. > ``` > * ERROR: gui-wm/hyprland-0.43.0::gentoo failed (setup phase): > * GCC version is too old to compile Hyprland! > ``` Hyprland uses new C++ features, it needs newish compilers. GCC 14 is stable so this shouldnt be an issue. Also please dont reuse bugs for unrelated issues. https://github.com/hyprwm/Hyprland/pull/7538/files Sam James, thank you. (In reply to Alfred Wingate from comment #13) > Hyprland uses new C++ features, it needs newish compilers. GCC 14 is stable > so this shouldnt be an issue. It's ~amd64 masked (same as hyprland 0.43) > Also please dont reuse bugs for unrelated issues. It's the same issue with missing `HYPRATOM` definition. I'm asking about -r2 coz latest working version for me is 0.41.1 that's already removed from portage. P.S. I will try, at least locally, to add patch by myself with this fix: https://github.com/hyprwm/Hyprland/pull/7538/files I don't know how to do PR, so if someone want to fix it locally:
mkdir -p /usr/local/portage/gui-wm/hyprland/files
cd /usr/local/portage/gui-wm/hyprland
cp /var/db/repos/gentoo/gui-wm/hyprland/hyprland-0.42.0-r1.ebuild ./hyprland-0.42.0-r2.ebuild
cat <<\EOF >> hyprland-0.42.0-r2.ebuild
if [[ "${PV}" = 0.42.0 ]]; then
PATCHES=(
"${FILESDIR}"/${PN}-0.42.0-xwayland-missing-macros.patch
)
fi
EOF
cat <<\EOF >> files/hyprland-0.42.0-xwayland-missing-macros.patch
--- a/src/xwayland/XWayland.hpp
+++ b/src/xwayland/XWayland.hpp
@@ -3,6 +3,7 @@
#include <memory>
#include "../helpers/signal/Signal.hpp"
#include "../helpers/memory/Memory.hpp"
+#include "../macros.hpp"
#include "XSurface.hpp"
EOF
ebuild hyprland-0.42.0-r2.ebuild digest
(In reply to Oleh Hordiienko from comment #15) Beauty. That sorted it for me as well! The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4a9b33d693e839c6e568c67bf6279d611bc25175 commit 4a9b33d693e839c6e568c67bf6279d611bc25175 Author: Julien Roy <julien@jroy.ca> AuthorDate: 2024-11-21 20:29:28 +0000 Commit: Yixun Lan <dlan@gentoo.org> CommitDate: 2024-11-21 23:17:12 +0000 gui-wm/hyprland: backport patch to build without X on gcc13 Bug: https://bugs.gentoo.org/935322 Closes: https://github.com/gentoo/gentoo/pull/39404 Signed-off-by: Julien Roy <julien@jroy.ca> Signed-off-by: Yixun Lan <dlan@gentoo.org> .../files/hyprland-0.42.0-no_xwayland.patch | 21 +++++ gui-wm/hyprland/hyprland-0.42.0-r2.ebuild | 104 +++++++++++++++++++++ 2 files changed, 125 insertions(+) I'd recommend filing a stablereq for that. |
too long lines were shrinked: [572/586] x86_64-pc-linux-gnu-g++ -Isrc/Hyprland.p -Isrc -I../hyprland-source/src -Isubprojects/wlroots-hyprland/include -I../hyprland-source/subprojects/wlroots-hyprland/include -Isubprojects/udis86 -I../hyprland-source/subprojects/udis86 -I../hyprland-source/subprojects/udis86/libudis86 -Isubproje [573/586] x86_64-pc-linux-gnu-g++ -Isrc/Hyprland.p -Isrc -I../hyprland-source/src -Isubprojects/wlroots-hyprland/include -I../hyprland-source/subprojects/wlroots-hyprland/include -Isubprojects/udis86 -I../hyprland-source/subprojects/udis86 -I../hyprland-source/subprojects/udis86/libudis86 -Isubproje [574/586] x86_64-pc-linux-gnu-g++ -Isrc/Hyprland.p -Isrc -I../hyprland-source/src -Isubprojects/wlroots-hyprland/include -I../hyprland-source/subprojects/wlroots-hyprland/include -Isubprojects/udis86 -I../hyprland-source/subprojects/udis86 -I../hyprland-source/subprojects/udis86/libudis86 -Isubproje FAILED: src/Hyprland.p/xwayland_XSurface.cpp.o x86_64-pc-linux-gnu-g++ -Isrc/Hyprland.p -Isrc -I../hyprland-source/src -Isubprojects/wlroots-hyprland/include -I../hyprland-source/subprojects/wlroots-hyprland/include -Isubprojects/udis86 -I../hyprland-source/subprojects/udis86 -I../hyprland-source/subprojects/udis86/libudis86 -Isubprojects/udis86 In file included from ../hyprland-source/src/xwayland/XSurface.cpp:2: ../hyprland-source/src/xwayland/XWayland.hpp:36:5: error: HYPRATOM was not declared in this scope 36 | HYPRATOM("_NET_SUPPORTED"), | ^~~~~~~~ ------------------------------------------------------------------- This is an unstable amd64 chroot image at a tinderbox (==build bot) name: 23.0-20240625-104003 UNMASKED: <sys-devel/gcc-15.0.9999:15 Please re-assign to toolchain@ if you get a test failure in C, C++, or Fortran code which makes no sense. ~dev-libs/icu-75.1 ~dev-libs/icu-layoutex-75.1 Requested by sam ~dev-lang/perl-5.40.0 ~virtual/perl-Archive-Tar-3.20.10_rc ~virtual/perl-CPAN-Meta-Requirements-2.143.0 ~virtual/perl-Compress-Raw-Bzip2-2.212.0 ~virtual/perl-DB_File-1.859.0 ~virtual/perl-Data-Dumper-2.189.0 ~virtual/perl-Devel-PPPort-3.720.0 ~virtual/perl-Exporter-5.780.0 ~virtual/perl-ExtUtils-CBuilder-0.280.240 ~virtual/perl-ExtUtils-Manifest-1.750.0 ~virtual/perl-File-Spec-3.900.0 ~virtual/perl-HTTP-Tiny-0.88.0 ~virtual/perl-IO-1.550.0 ~virtual/perl-IO-Compress-2.212.0 ~virtual/perl-IO-Socket-IP-0.420.0 ~virtual/perl-IO-Zlib-1.150.0 ~virtual/perl-Math-BigInt-2.3.2 ~virtual/perl-Math-BigInt-FastCalc-0.501.800 ~virtual/perl-Math-BigRat-2.3.2 ~virtual/perl-Module-CoreList-5.202.406.90 ~virtual/perl-Module-Metadata-1.0.38 ~virtual/perl-Pod-Simple-3.450.0 ~virtual/perl-Safe-2.460.0 ~virtual/perl-Socket-2.38.0 ~virtual/perl-Test-Harness-3.480.0 ~virtual/perl-Test-Simple-1.302.199 ~virtual/perl-Text-Tabs+Wrap-2024.1.0 ~virtual/perl-Time-HiRes-1.977.700 ~virtual/perl-Time-Local-1.350.0 ~virtual/perl-autodie-2.370.0 ~virtual/perl-bignum-0.670.0 ~virtual/perl-podlators-5.10.200_rc ~virtual/perl-threads-2.400.0 ~virtual/perl-threads-shared-1.690.0 ~virtual/perl-version-0.993.0 Requested by dilfridge and sam The attached etc.portage.tar.xz has all details. ------------------------------------------------------------------- gcc-config -l: [1] x86_64-pc-linux-gnu-15 * clang/llvm (if any): clang version 18.1.8 Target: x86_64-pc-linux-gnu Thread model: posix InstalledDir: /usr/lib/llvm/18/bin Configuration file: /etc/clang/x86_64-pc-linux-gnu-clang.cfg /usr/lib/llvm/18 18.1.8 Python 3.12.4 Available Rust versions: [1] rust-bin-1.79.0 [2] rust-1.79.0 * The following VMs are available for generation-2: 1) Eclipse Temurin JDK 11.0.23_p9 [openjdk-bin-11] 2) Eclipse Temurin JDK 17.0.11_p9 [openjdk-bin-17] *) Eclipse Temurin JDK 21.0.3_p9 [openjdk-bin-21] 4) Eclipse Temurin JDK 8.412_p08 [openjdk-bin-8] Available Java Virtual Machines: [1] openjdk-bin-8 [2] openjdk-bin-11 [3] openjdk-bin-17 [4] openjdk-bin-21 system-vm The Glorious Glasgow Haskell Compilation System, version 9.2.8 php cli (if any): go version go1.22.4 linux/amd64 HEAD of ::gentoo commit 6871287bed28eba3d17577ac48686bf1b40c672c Author: Repository mirror & CI <repomirrorci@gentoo.org> Date: Tue Jul 2 00:19:04 2024 +0000 2024-07-02 00:19:03 UTC emerge -qpvO gui-wm/hyprland