Bug 935160

Summary:	[guru] net-p2p/monero-0.18.3.3 fails to compile: net_node.inl:2992:30: error: too few arguments to function int UPNP_GetValidIGD(UPNPDev, UPNPUrls, IGDdatas, char, int, char, int)
Product:	GURU	Reporter:	Agostino Sarubbo <ago>
Component:	Package issues	Assignee:	Efe İzbudak <efe.izbudak>
Status:	RESOLVED FIXED
Severity:	normal	CC:	benoit.dufour, fkobi, g00g1+gentoo.org, guru-bugs, gustav.schaffter
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	build.log monero-18.3.3-miniupnp-api-18.patch monero-18.3.3-miniupnp-api-18-rev1.patch

Description Agostino Sarubbo gentoo-dev

2024-06-30 06:28:42 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: net-p2p/monero-0.18.3.3 fails to compile.
Discovered on: amd64 (internal ref: guru_ci)

Info about the issue:
https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#CF0014

Comment 1 Agostino Sarubbo gentoo-dev

2024-06-30 06:28:43 UTC

Created attachment 896644 [details]
build.log

build log and emerge --info

Comment 2 Agostino Sarubbo gentoo-dev

2024-06-30 06:28:44 UTC

Error(s) that match a know pattern in addition to what has been reported in the summary:


  lrelease program not found, translation files not built
-- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE) 
-- Could NOT find HIDAPI (missing: HIDAPI_LIBRARY HIDAPI_INCLUDE_DIR) 
-- Could not find DEVELOPER_LOCAL_TOOLS in env (not required)
-- Could not find HIDAPI
FAILED: src/rpc/CMakeFiles/obj_rpc.dir/instanciations.cpp.o 
fatal: not a git repository (or any parent up to mount point /var/tmp)
/var/tmp/portage/net-p2p/monero-0.18.3.3/work/monero-0.18.3.3/src/p2p/net_node.inl:2992:30: error: too few arguments to function ‘int UPNP_GetValidIGD(UPNPDev*, UPNPUrls*, IGDdatas*, char*, int, char*, int)’

Comment 3 benoit.dufour 2024-07-01 22:39:03 UTC

Created attachment 896739 [details, diff]
monero-18.3.3-miniupnp-api-18.patch

Here's a patch that should fix the issue.

Comment 4 benoit.dufour 2024-07-01 23:00:57 UTC

Comment on attachment 896739 [details, diff]
monero-18.3.3-miniupnp-api-18.patch

>diff --git a/src/p2p/net_node.inl b/src/p2p/net_node.inl
>index 30e3d31b9..9eafc12cd 100644
>--- a/src/p2p/net_node.inl
>+++ b/src/p2p/net_node.inl
>@@ -3057,7 +3057,12 @@ namespace nodetool
>     UPNPUrls urls;
>     IGDdatas igdData;
>     char lanAddress[64];
>+#if MINIUPNPC_API_VERSION > 17
>+    char wanAddress[64];
>+    result = UPNP_GetValidIGD(deviceList, &urls, &igdData, lanAddress, sizeof lanAddress, wanAddress, sizeof(wanAddress));
>+#else
>     result = UPNP_GetValidIGD(deviceList, &urls, &igdData, lanAddress, sizeof lanAddress);
>+#endif
>     freeUPNPDevlist(deviceList);
>     if (result > 0) {
>       if (result == 1) {

Comment 5 benoit.dufour 2024-07-01 23:13:29 UTC

Created attachment 896742 [details, diff]
monero-18.3.3-miniupnp-api-18-rev1.patch

The previous patch I made was broken and only fixed one of the two calls to UPNP_GetValidIGD. This one fix both and isn't broken, so it now compiles.

Comment 6 Filip Kobierski 2024-07-27 21:22:59 UTC

I have fixed it in https://gitweb.gentoo.org/repo/proj/guru.git/commit/?h=dev&id=aedc02ff3297b1d82263925c6a5d79188f7b5dbd
but forgot to add Closes and I cannot force push.

Can someone please close this?