Bug 935072

Summary:	xfce-base/tumbler-4.18.2 no thumbnails for .avi files
Product:	Gentoo Linux	Reporter:	David Duchesne <aether>
Component:	Current packages	Assignee:	XFCE Team <xfce>
Status:	UNCONFIRMED ---
Severity:	normal	CC:	aether
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	xfce-base/tumbler-4.18.2-fix-avi-thumbnails.diff

Description David Duchesne 2024-06-28 19:39:16 UTC

Hello,
xfce-base/tumbler-4.18.2 fails to display thumbnails for .avi files.

x11-misc/shared-mime-info-2.4-r1 changed type from video/x-msvideo to video/vnd.avi
in tumbler src, mime are hardcoded or use ffmpegthumbnailer values if I understand correctly (which is broken by the change too : https://github.com/dirkvdb/ffmpegthumbnailer/issues/231)

tumbler/plugins/ffmpeg-thumbnailer/ffmpeg-thumbnailer-provider.c at line 97
----
static GList *
ffmpeg_thumbnailer_provider_get_thumbnailers (TumblerThumbnailerProvider *provider)
à{
  static const gchar *mime_types[] =
  {
    "video/jpeg",
    "video/mp4",
    "video/mp2t",
    "video/mpeg",
    "video/quicktime",
    "video/x-ms-asf",
    "video/x-ms-wm",
    "video/x-ms-wmv",
    "video/x-msvideo",
    "video/x-flv",
    "application/x-flash-video",
    "application/vnd.rn-realmedia",
    "video/3gpp",
    "video/x-matroska",
    "video/ogg",
    "video/webm",
    NULL
  };
  FfmpegThumbnailer  *thumbnailer;
  GList              *thumbnailers = NULL;
  GStrv               uri_schemes;
----

The easy fix was to add "video/vnd.avi" (patch linked)
Unfortunately, I can't open a bug upstream because I don't have a gitlab account.


Reproducible: Always

Comment 1 David Duchesne 2024-06-28 19:40:40 UTC

Created attachment 896587 [details, diff]
xfce-base/tumbler-4.18.2-fix-avi-thumbnails.diff