Summary: | dev-qt/qtwebengine-6.7.2 USE="pdfium -pulseaudio": Package 'libpulse' not found | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | J.Borme <gentoo_bugs.nu_q5v> |
Component: | Current packages | Assignee: | Qt Bug Alias <qt> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | gentoo_bugs.nu_q5v, ionen |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | build log |
Description
J.Borme
2024-06-20 21:06:32 UTC
Created attachment 896177 [details]
build log
Hm, I couldn't reproduce at first and it built fine without libpulse by passing use_pulseaudio=false thus never calling that bit... but if I enable USE=pdfium, then it the use_pulseaudio is never passed and is left enabled by default. Haven't looked at why yet. Did USE="pdfium -pulseaudio" use to work for you with 6.7.1, or is it the first time you've either used that combination or 6.7.2? I don't think I ever tested that combination myself (given long build I typically do minimal testing for that one), so wondering if it's been broken for a while. (In reply to Ionen Wolkens from comment #3) > Did USE="pdfium -pulseaudio" use to work for you with 6.7.1, or is it the > first time you've either used that combination or 6.7.2? Meant to say "or qtwebengine-6.x" Well, either way no harm in fixing 6.7.1 as well. Can easily workaround this without patching anything using an explicit `use_pulseaudio=$(usex pulseaudio true false)` rather than rely on Qt to pass it for pdfium, the option ends up duplicated for the normal core build but that's harmless. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a3342167040e3534ea627b7ee3d7f123727cf064 commit a3342167040e3534ea627b7ee3d7f123727cf064 Author: Ionen Wolkens <ionen@gentoo.org> AuthorDate: 2024-06-21 00:42:59 +0000 Commit: Ionen Wolkens <ionen@gentoo.org> CommitDate: 2024-06-21 00:53:14 +0000 dev-qt/qtwebengine: fix build with USE="pdfium -pulseaudio" (qt6) Or hopefully anyway, have not tested the full build without libpulse, but it at least no longer looks for it. Unclear whether pdfium was automagically linking with it, or just looking for it for nothing while unused. The former technically needs a revbump, but not worth it given the long build times and how pdfium is scarcely used. Closes: https://bugs.gentoo.org/934635 Signed-off-by: Ionen Wolkens <ionen@gentoo.org> dev-qt/qtwebengine/qtwebengine-6.7.1.ebuild | 2 ++ dev-qt/qtwebengine/qtwebengine-6.7.2.ebuild | 2 ++ dev-qt/qtwebengine/qtwebengine-6.7.9999.ebuild | 2 ++ dev-qt/qtwebengine/qtwebengine-6.8.9999.ebuild | 2 ++ dev-qt/qtwebengine/qtwebengine-6.9999.ebuild | 2 ++ 5 files changed, 10 insertions(+) The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a2dfd665eeb527282c2bc51756b2881c134ce8b4 commit a2dfd665eeb527282c2bc51756b2881c134ce8b4 Author: Ionen Wolkens <ionen@gentoo.org> AuthorDate: 2024-06-21 01:00:40 +0000 Commit: Ionen Wolkens <ionen@gentoo.org> CommitDate: 2024-06-21 01:03:45 +0000 dev-qt/qtwebengine: alternate fix for USE="pdfium -pulseaudio" (qt6) Just realized the issue is self-inflicted. The pkg-config check is done only if "use_pulseaudio && link_pulseaudio" and the latter is passed by us rather than Qt. It seemed harmless to be unconditional given the main switch disabled it (which technically sounds better), but given it doesn't for pdfium let's change that and do it for pipewire as well while at it. Bug: https://bugs.gentoo.org/934635 Signed-off-by: Ionen Wolkens <ionen@gentoo.org> dev-qt/qtwebengine/qtwebengine-6.7.1.ebuild | 6 ++---- dev-qt/qtwebengine/qtwebengine-6.7.2.ebuild | 6 ++---- dev-qt/qtwebengine/qtwebengine-6.7.9999.ebuild | 6 ++---- dev-qt/qtwebengine/qtwebengine-6.8.9999.ebuild | 6 ++---- dev-qt/qtwebengine/qtwebengine-6.9999.ebuild | 6 ++---- 5 files changed, 10 insertions(+), 20 deletions(-) (In reply to Ionen Wolkens from comment #3) Indeed it failed to rebuild qtwebengine-6.7.1 when portage asked for USE=pdfium. I had forgotten about this part. I can confirm your commit solves the problem with 6.7.2 |