Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 934531

Summary: dev-embedded/libftdi-1.5-r6 has py312.patch in wrong position
Product: Gentoo Linux Reporter: Flavio Cappelli <flavio.cappelli>
Component: Current packagesAssignee: Embedded Gentoo Team <embedded>
Status: RESOLVED FIXED    
Severity: normal CC: flavio.cappelli, sam
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: The attached ebuild fix the issue.

Description Flavio Cappelli 2024-06-19 02:20:16 UTC
In current libftdi-1.5-r6.ebuild, "py312.patch" overrides the other two patches ("tests-no-cxx.patch" and "cmake-cxx.patch"). The effect is that 'libftdi1-config --cflags' and '/usr/lib64/pkgconfig/libftdi1.pc' both return the wrong path for 'ftdi.h', breaking some other ebuilds depending on dev-embedded/libftdi:


libftdi-1.5-r6 (WRONG)
----------------------
/usr/include/libftdi1/ftdi.h

libftdi1-config --cflags   -->   -I/usr/include/libftdipp1

/usr/lib64/pkgconfig/libftdi1.pc   -->   includedir=/usr/include/libftdipp1


libftdi-1.5-r5 (OK)
-------------------
/usr/include/libftdi1/ftdi.h

libftdi1-config --cflags   -->   -I/usr/include/libftdi1

/usr/lib64/pkgconfig/libftdi1.pc   -->   includedir=/usr/include/libftdi1
Comment 1 Flavio Cappelli 2024-06-19 02:22:06 UTC
Created attachment 896053 [details]
The attached ebuild fix the issue.
Comment 2 Larry the Git Cow gentoo-dev 2024-06-19 13:18:56 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=062d40262791666f7bf2042c3d74efd2368ca637

commit 062d40262791666f7bf2042c3d74efd2368ca637
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-06-19 13:18:19 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-06-19 13:18:30 +0000

    dev-embedded/libftdi: fix PATCHES
    
    Closes: https://bugs.gentoo.org/934531
    Signed-off-by: Sam James <sam@gentoo.org>

 .../libftdi/{libftdi-1.5-r6.ebuild => libftdi-1.5-r7.ebuild}       | 7 ++-----
 dev-embedded/libftdi/libftdi-9999.ebuild                           | 7 +------
 2 files changed, 3 insertions(+), 11 deletions(-)
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-06-19 13:20:26 UTC
Thanks and apologies for the error. That's why I like having the variables listed in standard locations.