Bug 933747

Summary:	media-sound/whipper-0.10.0-r1 needs media-libs/libsndfile[-minimal] for AccurateRip to work
Product:	Gentoo Linux	Reporter:	Johannes Schmidt <schmidtjoh>
Component:	Current packages	Assignee:	Quentin Retornaz <gentoo>
Status:	RESOLVED FIXED
Severity:	normal	CC:	gentoo, gentoo, proxy-maint
Priority:	Normal	Keywords:	PullRequest
Version:	unspecified
Hardware:	AMD64
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/37088
Whiteboard:
Package list:		Runtime testing required:	---

Description Johannes Schmidt 2024-06-07 14:29:39 UTC

If media-libs/libsndfile is installed with the minimal flag, AccurateRip checks fail with messages like this:

ERROR:whipper.common.accurip:could not calculate AccurateRip v1 checksum for track 10 '~/rip/track10.flac'
ERROR:whipper.common.accurip:could not calculate AccurateRip v2 checksum for track 10 '~/rip/track10.flac'
ERROR:whipper.common.accurip:no track AR CRC on non-HTOA track 1
track  1: unknown          (error)

With USE=-minimal (and the ripped files deleted so whipper will repeat the rip) the error is gone and AccurateRip reports a succes.

Reproducible: Always

Steps to Reproduce:
1. Install media-libs/libsndfile with USE=minimal
2. whipper cd rip
Actual Results:  
The error above is displayed and now AccurateRip checks are performed or results shown.

Expected Results:  
AccurateRip checks are performed correctly.

Comment 1 Quentin Retornaz 2024-06-09 00:51:18 UTC

Fix in PR 37088

Comment 2 Larry the Git Cow gentoo-dev

2024-07-13 07:35:02 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=eb86a9e0ceadb3f707e2a95b8adc76bfb9ca9f0d

commit eb86a9e0ceadb3f707e2a95b8adc76bfb9ca9f0d
Author:     Quentin Retornaz <gentoo@retornaz.com>
AuthorDate: 2024-06-09 00:38:26 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2024-07-13 07:34:49 +0000

    media-sound/whipper: fix DEPEND="media-libs/libsndfile[-minimal]"
    
    Closes: https://bugs.gentoo.org/933747
    Signed-off-by: Quentin Retornaz <gentoo@retornaz.com>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 media-sound/whipper/whipper-0.10.0-r3.ebuild | 56 ++++++++++++++++++++++++++++
 1 file changed, 56 insertions(+)