Bug 933186 – [guru] app-admin/hardinfo2-2.2.1 overwrites CFLAGS/CXXFLAGS or adds uncommon ones

• Product: GURU
• Status: CONFIRMED ---

[Description Agostino Sarubbo 2024-05-30 10:22:45 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: app-admin/hardinfo2-2.1.11 overwrites CFLAGS/CXXFLAGS or adds uncommon ones.
Discovered on: amd64 (internal ref: guru_ci)

Info about the issue:
https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#QA0069

[Comment 1 Agostino Sarubbo 2024-05-30 10:22:46 UTC]

Created attachment 894650 [details]
build.log

build log and emerge --info

[Comment 2 Quincy Fleming 2024-05-30 19:41:28 UTC]

Can we make an exception for this?  The developer insists optimization flags should be turned off just for compiling these parts of the code as defined here in CMakeLists.txt:313-320

set_source_files_properties(
	modules/benchmark/blowfish.c
	modules/benchmark/fftbench.c
	modules/benchmark/md5.c
	modules/benchmark/sha1.c
	PROPERTIES
	COMPILE_FLAGS "-O0 -Wall -Wextra -Werror=implicit-function-declaration"
)

The developer states the reason in modules/benchmark/md5.c:34-36 and in
modules/benchmark/sha1.c:36-38

#if defined(__OPTIMIZE__)
#error You must compile this program without "-O". (Or else the benchmark results may be different!)
#endif

which will cause the program to not compile if optimizations are turned on for this part of the code. I can just remove those 3 lines of code from both modules/benchmark/md5.c and modules/benchmark/sha1.c, and remove the -O0 flag from CMakeLists.txt and it will compile just fine but benchmark results may be different as the developer states.

[Comment 3 Agostino Sarubbo 2024-08-06 07:11:43 UTC]

guru_ci has reproduced this issue with version 2.1.11-r1 - Updating summary.

[Comment 4 Agostino Sarubbo 2024-09-09 12:54:01 UTC]

guru_ci has reproduced this issue with version 2.1.14 - Updating summary.

[Comment 5 Agostino Sarubbo 2024-10-04 07:08:36 UTC]

guru_ci has reproduced this issue with version 2.1.17 - Updating summary.

[Comment 6 Agostino Sarubbo 2024-11-03 08:06:09 UTC]

guru_ci has reproduced this issue with version 2.2.1 - Updating summary.