Bug 932486

Summary:	[guru] net-p2p/feather-2.6.7 fails to compile: portable_storage_val_converters.h:63:49: error: boost::numeric has not been declared
Product:	GURU	Reporter:	Agostino Sarubbo <ago>
Component:	Package issues	Assignee:	Adam <adam.pimentel46>
Status:	RESOLVED OBSOLETE
Severity:	normal	CC:	adam.pimentel46, guru-bugs, neb.semqen.ramesses, tea+gentoo, watermanpaint
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2024-05-22 15:03:16 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: net-p2p/feather-2.6.2 fails to compile.
Discovered on: amd64 (internal ref: guru_tinderbox)
System: GCC-14-SYSTEM (https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#GCC-14)

Info about the issue:
https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#CF0003

Comment 1 Agostino Sarubbo gentoo-dev

2024-05-22 15:03:17 UTC

Created attachment 893869 [details]
build.log

build log and emerge --info

Comment 2 Agostino Sarubbo gentoo-dev

2024-05-22 15:03:18 UTC

Error(s) that match a know pattern in addition to what has been reported in the summary:


  lrelease program not found, translation files not built
-- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE) 
-- Could NOT find HIDAPI (missing: HIDAPI_LIBRARY HIDAPI_INCLUDE_DIR) 
-- Could not find DEVELOPER_LOCAL_TOOLS in env (not required)
-- Could not find HIDAPI
FAILED: monero/contrib/epee/src/CMakeFiles/obj_epee.dir/portable_storage.cpp.o 
fatal: not a git repository (or any parent up to mount point /var/tmp)
/var/tmp/portage/net-p2p/feather-2.6.2/work/feather-2.6.2/monero/contrib/epee/include/storages/portable_storage_val_converters.h:63:49: error: ‘boost::numeric’ has not been declared

Comment 3 Agostino Sarubbo gentoo-dev

2024-05-30 10:21:15 UTC

guru_ci has reproduced this issue with version 2.6.7 - Updating summary.

Comment 4 tea 2024-07-12 15:48:21 UTC

upstream issue: <https://github.com/feather-wallet/feather/issues/190>
this fix works for me: <https://github.com/feather-wallet/monero/compare/ad951be2edfb3045ec3d0bb74a25badb91bc8b92...5d4d1e8f6854baa894f738d373cfee79e6d4eba2#diff-ce01bdf6360733c69bc3243a9f3c6079aa6644713ceb159eb3d65351c5688f27.patch> (had to edit in the “monero” subdirectory)

Comment 5 Adam 2024-07-16 03:06:45 UTC

It seems like the upstream developer has a new release format so I just re-wrote this package to make it simpler (by using their vendored libraries), and this new feather-2.6.7-r1 ebuild should work.

Sorry about the delay, i have kind of neglected these ebuilds. If anyone else (presumably someone who knows what they are doing) wants to take ownership of this ebuild, go ahead. I am only maintaining these (P2Pool and feather) because the previous owners gave up after I complained about them not updating fast enough.

Comment 6 Lucio Sauer 2024-08-01 22:04:02 UTC

Adam, if you fixed this in https://gitweb.gentoo.org/repo/proj/guru.git/commit/net-p2p/feather/feather-2.6.7-r1.ebuild?id=82333b2b1fe208637962287d7e8e6b985ae23f3a, the correct resolution would be FIXED, not OBSOLETE.

Comment 7 Adam 2024-08-02 00:16:59 UTC

(In reply to Lucio Sauer from comment #6)
> Adam, if you fixed this in
> https://gitweb.gentoo.org/repo/proj/guru.git/commit/net-p2p/feather/feather-
> 2.6.7-r1.ebuild?id=82333b2b1fe208637962287d7e8e6b985ae23f3a, the correct
> resolution would be FIXED, not OBSOLETE.

Does it count as obsoleting or fixing the bug if the ebuild updates but the upstream software did not update, and the ebuild change fixes it as a side-effect?

Going forwards, i'll file these types of changes as FIXED.