Summary: | app-shells/gentoo-bashcomp: fix portageq envvar warnings and improve completion results | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Lucio Sauer <watermanpaint> |
Component: | Current packages | Assignee: | Gentoo Shell Tools project <shell-tools> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | watermanpaint |
Priority: | Normal | Keywords: | PATCH |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.gentoo.org/show_bug.cgi?id=588642 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
Patch to fix command validation warnings
Patch to fix variables selected for completion Patch to fix variables selected for completion -- v2 |
Description
Lucio Sauer
2024-05-10 13:00:41 UTC
Created attachment 892657 [details, diff]
Patch to fix command validation warnings
I also thought about not purging the environment before running emerge -v --info, but I believe we should avoid completing variables that Portage should ignore anyways (?).
Created attachment 892658 [details, diff]
Patch to fix variables selected for completion
Created attachment 892659 [details, diff]
Patch to fix variables selected for completion -- v2
I added this bug to the `Closes:` commit tag.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/proj/gentoo-bashcomp.git/commit/?id=63aae2a1775e501678290c6dbeac53215decffc2 commit 63aae2a1775e501678290c6dbeac53215decffc2 Author: Lucio Sauer <watermanpaint@posteo.net> AuthorDate: 2024-05-10 12:07:16 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-05-11 03:11:51 +0000 portageq envvar: fix variables selected for completion With lines like VAR="foo" BAZ="1 2 3", \(.*\)=".*$ not only matches VAR, but also VAR="foo" BAZ. This applies at line ^USE=.*, where the regular USE flags are followed by a list of all present USE_EXPAND variables together with their respective values. The current sed invocation also ignores environment variables that start with a lowercase letter, such as gl_cv_compiler_check_decl_option. Closes: https://bugs.gentoo.org/931671 Signed-off-by: Lucio Sauer <watermanpaint@posteo.net> Signed-off-by: Sam James <sam@gentoo.org> completions/portageq | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Thank you! I forgot to add the bug tag to the first commit. commit aa32f1e126bdf947efc012d4d6b93a7150d74b24 Author: Lucio Sauer <watermanpaint@posteo.net> Date: Fri May 10 13:59:16 2024 +0200 portageq envvar: preserve PATH to avoid command validation warnings Some of Portage's environment variables undergo command validation. When one is set to a relative value, Portage relies on PATH to find the binary. We need to preserve it after purging the environment (`env -i`) if we want to avoid "<key> is invalid: <value>" warnings. For Portage 3.0.63, this affects PORTAGE_{B{,UN}ZIP2_COMMAND,LOG_FILTER_FILE_CMD}. Bug: https://bugs.gentoo.org/588642 Signed-off-by: Lucio Sauer <watermanpaint@posteo.net> Signed-off-by: Sam James <sam@gentoo.org> I'll make a new release, but please feel free to send any other patches for gentoo-bashcomp too. Thanks again! The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5af5f9898cfe42bbff09e720ce6ccd7eb1e002db commit 5af5f9898cfe42bbff09e720ce6ccd7eb1e002db Author: Sam James <sam@gentoo.org> AuthorDate: 2024-05-11 03:14:34 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-05-11 03:14:34 +0000 app-shells/gentoo-bashcomp: add 20240511 Lucio Sauer (2): portageq envvar: preserve PATH to avoid command validation warnings portageq envvar: fix variables selected for completion Sam James (8): completions/emerge: add additional options completions/emerge: add --verbose-conflicts completions/emerge: add --with-test-deps helpers/gentoo-common.sh: fix whitespace completions/emerge: add --changed-* options completions/emerge: add various further options completions/emerge: fix indentation Makefile: bzip2 -> xz Bug: https://bugs.gentoo.org/588642 Bug: https://bugs.gentoo.org/931671 Signed-off-by: Sam James <sam@gentoo.org> app-shells/gentoo-bashcomp/Manifest | 1 + .../gentoo-bashcomp/gentoo-bashcomp-20240511.ebuild | 21 +++++++++++++++++++++ 2 files changed, 22 insertions(+) |