Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 931256

Summary: net-libs/nodejs-22.1.0 FAILED: mmksnapshot
Product: Gentoo Linux Reporter: Andrew Cameron <apcameron>
Component: Current packagesAssignee: William Hubbs <williamh>
Status: RESOLVED FIXED    
Severity: normal CC: apcameron, chris, dlan, jstein, matoro_gentoo, riscv
Priority: Normal Keywords: PullRequest
Version: unspecified   
Hardware: riscv   
OS: Linux   
See Also: https://github.com/nodejs/node/pull/52888
https://github.com/gentoo/gentoo/pull/37068
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: Info
Environment
pqv log
Build log

Description Andrew Cameron 2024-05-05 15:38:00 UTC 
[1688/1890] riscv64-unknown-linux-gnu-g++ -Wl,-O1 -Wl,--as-needed -pthread -rdynamic -o mksnapshot -Wl,--start-group obj/deps/v8/src/snapshot/embedded/mksnapshot.embedded-empty.o obj/deps/v8/src/snapshot/embedded/mksnapshot.embedded-file-writer.o obj/deps/v8/src/snapshot/embedded/mksnapshot.platform-embedded-file-writer-aix.o obj/deps/v8/src/snapshot/embedded/mksnapshot.platform-embedded-file-writer-base.o obj/deps/v8/src/snapshot/embedded/mksnapshot.platform-embedded-file-writer-generic.o obj/deps/v8/src/snapshot/embedded/mksnapshot.platform-embedded-file-writer-mac.o obj/deps/v8/src/snapshot/embedded/mksnapshot.platform-embedded-file-writer-win.o obj/deps/v8/src/snapshot/mksnapshot.mksnapshot.o obj/deps/v8/src/snapshot/mksnapshot.snapshot-empty.o obj/deps/v8/src/snapshot/mksnapshot.static-roots-gen.o obj/tools/v8_gypfiles/libv8_base_without_compiler.a obj/tools/v8_gypfiles/libv8_init.a obj/tools/v8_gypfiles/libv8_libbase.a obj/tools/v8_gypfiles/libv8_libplatform.a obj/tools/v8_gypfiles/libv8_turboshaft.a obj/tools/v8_gypfiles/libv8_abseil.a obj/tools/v8_gypfiles/libv8_zlib.a obj/tools/v8_gypfiles/libv8_compiler.a obj/tools/v8_gypfiles/libv8_initializers.a obj/tools/v8_gypfiles/libv8_initializers_slow.a  -lz -luv -lbrotlidec -lbrotlienc -lcares -lnghttp2 -lcrypto -lssl -licui18n -licuuc -licudata -latomic -ldl -lrt -Wl,--end-group
^[[31mFAILED: ^[[0mmksnapshot
riscv64-unknown-linux-gnu-g++ -Wl,-O1 -Wl,--as-needed -pthread -rdynamic -o mksnapshot -Wl,--start-group obj/deps/v8/src/snapshot/embedded/mksnapshot.embedded-empty.o obj/deps/v8/src/snapshot/embedded/mksnapshot.embedded-file-writer.o obj/deps/v8/src/snapshot/embedded/mksnapshot.platform-embedded-file-writer-aix.o obj/deps/v8/src/snapshot/embedded/mksnapshot.platform-embedded-file-writer-base.o obj/deps/v8/src/snapshot/embedded/mksnapshot.platform-embedded-file-writer-generic.o obj/deps/v8/src/snapshot/embedded/mksnapshot.platform-embedded-file-writer-mac.o obj/deps/v8/src/snapshot/embedded/mksnapshot.platform-embedded-file-writer-win.o obj/deps/v8/src/snapshot/mksnapshot.mksnapshot.o obj/deps/v8/src/snapshot/mksnapshot.snapshot-empty.o obj/deps/v8/src/snapshot/mksnapshot.static-roots-gen.o obj/tools/v8_gypfiles/libv8_base_without_compiler.a obj/tools/v8_gypfiles/libv8_init.a obj/tools/v8_gypfiles/libv8_libbase.a obj/tools/v8_gypfiles/libv8_libplatform.a obj/tools/v8_gypfiles/libv8_turboshaft.a obj/tools/v8_gypfiles/libv8_abseil.a obj/tools/v8_gypfiles/libv8_zlib.a obj/tools/v8_gypfiles/libv8_compiler.a obj/tools/v8_gypfiles/libv8_initializers.a obj/tools/v8_gypfiles/libv8_initializers_slow.a  -lz -luv -lbrotlidec -lbrotlienc -lcares -lnghttp2 -lcrypto -lssl -licui18n -licuuc -licudata -latomic -ldl -lrt -Wl,--end-group
/usr/lib/gcc/riscv64-unknown-linux-gnu/13/../../../../riscv64-unknown-linux-gnu/bin/ld: obj/tools/v8_gypfiles/../../deps/v8/src/api/v8_base_without_compiler.api.o: in function `v8::TryHandleWebAssemblyTrapPosix(int, siginfo_t*, void*)':
api.cc:(.text._ZN2v829TryHandleWebAssemblyTrapPosixEiP9siginfo_tPv+0x0): undefined reference to `v8::internal::trap_handler::TryHandleSignal(int, siginfo_t*, void*)'
/usr/lib/gcc/riscv64-unknown-linux-gnu/13/../../../../riscv64-unknown-linux-gnu/bin/ld: obj/tools/v8_gypfiles/../../deps/v8/src/trap-handler/v8_base_without_compiler.handler-outside.o: in function `v8::internal::trap_handler::EnableTrapHandler(bool)':
handler-outside.cc:(.text._ZN2v88internal12trap_handler17EnableTrapHandlerEb+0x50): undefined reference to `v8::internal::trap_handler::RegisterDefaultTrapHandler()'
collect2: error: ld returned 1 exit status
Comment 1 Andrew Cameron 2024-05-05 15:38:30 UTC 
Created attachment 892306 [details]
Info
Comment 2 Andrew Cameron 2024-05-05 15:38:57 UTC 
Created attachment 892307 [details]
Environment
Comment 3 Andrew Cameron 2024-05-05 15:39:30 UTC 
Created attachment 892308 [details]
pqv log
Comment 4 Andrew Cameron 2024-05-05 15:40:14 UTC 
Created attachment 892309 [details]
Build log
Comment 5 Yixun Lan archtester gentoo-dev 2024-05-08 13:48:43 UTC 
with this patch from the PR, this bug actually got fixed, I've tested on riscv64 machine
Comment 6 Jakov Smolić archtester gentoo-dev 2024-06-06 01:18:00 UTC 
*** Bug 933649 has been marked as a duplicate of this bug. ***
Comment 7 Larry the Git Cow gentoo-dev 2024-06-25 16:45:35 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=da1119fa36aa12fbb367ea13b618c8f2102b750b

commit da1119fa36aa12fbb367ea13b618c8f2102b750b
Author:     Jakov Smolić <jsmolic@gentoo.org>
AuthorDate: 2024-06-07 10:00:09 +0000
Commit:     Jakov Smolić <jsmolic@gentoo.org>
CommitDate: 2024-06-25 16:44:57 +0000

    net-libs/nodejs: Fix building on riscv
    
    Closes: https://bugs.gentoo.org/931256
    Signed-off-by: Jakov Smolić <jsmolic@gentoo.org>
    Closes: https://github.com/gentoo/gentoo/pull/37068
    Signed-off-by: Jakov Smolić <jsmolic@gentoo.org>

 net-libs/nodejs/files/nodejs-22.2.0-riscv.patch | 37 +++++++++++++++++++++++++
 net-libs/nodejs/nodejs-22.3.0.ebuild            |  3 ++
 2 files changed, 40 insertions(+)
Comment 8 Christopher May-Townsend 2024-07-07 11:04:52 UTC 
Not sure if this ticket is the best place to comment but nodejs-22.4.0 fails on riscv due to missing patch;

>>> Preparing source in /var/tmp/portage/net-libs/nodejs-22.4.0/work/node-v22.4.0 ...
 * Applying nodejs-22.4.0-riscv.patch ...
/var/tmp/portage/net-libs/nodejs-22.4.0/temp/environment: line 1611: /var/tmp/portage/net-libs/nodejs-22.4.0/files/nodejs-22.4.0-riscv.patch: No such file or directory
/var/tmp/portage/net-libs/nodejs-22.4.0/temp/environment: line 1614: /var/tmp/portage/net-libs/nodejs-22.4.0/files/nodejs-22.4.0-riscv.patch: No such file or directory                       [ !! ]

The file is present is;

nodejs-22.2.0-riscv.patch
Comment 9 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-07-07 11:08:07 UTC 
(In reply to Christopher May-Townsend from comment #8)

commit 3be56b29d7eecc7aac7f8dea4409217f2ebe4f64
Author: Jakov Smolić <jsmolic@gentoo.org>
Date:   Sat Jul 6 15:14:57 2024 +0200

    net-libs/nodejs: Apply riscv patch to version 22.4.0

    Closes: https://bugs.gentoo.org/935566
    Signed-off-by: Jakov Smolić <jsmolic@gentoo.org>