Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 930996

Summary: sys-apps/dcfldd: consider adding patch to fix aliasing UB
Product: Gentoo Linux Reporter: Sam James <sam>
Component: Current packagesAssignee: Sebastian Pipping <sping>
Status: RESOLVED FIXED    
Severity: normal CC: esigra, sping
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/resurrecting-open-source-projects/dcfldd/pull/24
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114698
https://github.com/NetBSD/pkgsrc/issues/122
https://github.com/archiecobbs/libnbcompat/issues/4
https://bugs.gentoo.org/show_bug.cgi?id=931266
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 915000    

Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-05-01 03:35:29 UTC
dcfldd's SHA2 implementation has some cargo-culted alias violations. Please consider pulling in https://github.com/resurrecting-open-source-projects/dcfldd/pull/24 which I submitted after noticing a GCC bug report (which ended up being bogus).
Comment 1 Sebastian Pipping gentoo-dev 2024-05-01 19:12:41 UTC
Thanks for raising awareness and creating a pull request upstream, where I replied just now.  I would like to fully understand it first and see if upstream joins the discussion.  Let's give them a few days.
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-05-02 05:20:30 UTC
Merged upstream.
Comment 3 Larry the Git Cow gentoo-dev 2024-05-05 20:15:09 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=670caca7e19121f32709d524fc6c42a921866479

commit 670caca7e19121f32709d524fc6c42a921866479
Author:     Sebastian Pipping <sping@gentoo.org>
AuthorDate: 2024-05-05 20:13:23 +0000
Commit:     Sebastian Pipping <sping@gentoo.org>
CommitDate: 2024-05-05 20:13:23 +0000

    sys-apps/dcfldd: Fix miscompilation through Sam's upstream patch
    
    Closes: https://bugs.gentoo.org/930996
    Signed-off-by: Sebastian Pipping <sping@gentoo.org>

 sys-apps/dcfldd/dcfldd-1.9.1-r2.ebuild             | 37 ++++++++++++++++++
 .../dcfldd/files/dcfldd-1.9.1-miscompile.patch     | 44 ++++++++++++++++++++++
 2 files changed, 81 insertions(+)