Bug 930550

Summary:	java-pkg-simple.eclass should also allow java-pkg-opt-2
Product:	Gentoo Linux	Reporter:	Volkmar W. Pogatzki <gentoo>
Component:	Eclasses	Assignee:	Java team <java>
Status:	RESOLVED FIXED
Severity:	normal	CC:	fordfrog, gentoo
Priority:	Normal	Keywords:	PullRequest
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/37468
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	allow_java-pkg-opt-2.patch proposed by Alfred Wingate on #gentoo-dev-help on 2024-04-25

Description Volkmar W. Pogatzki 2024-04-24 09:48:10 UTC

Presently, "java-pkg-simple eclass can only be inherited AFTER java-pkg-2".
But, there are packages like dev-lang/cxprolog with optional Java which could use 
java-pkg-opt-2 instead of java-pkg-2.

Emerging such a package inheriting java-pkg-simple.eclass instead of java-ant-2.eclass presently throws this message after installation:

>>> Regenerating /etc/ld.so.cache...

>>> Completed (1 of 1) dev-lang/cxprolog-0.98.2-r2::testing
 * Messages for package dev-lang/cxprolog-0.98.2-r2:
 * java-pkg-simple eclass can only be inherited AFTER java-pkg-2



 * GNU info directory index is up-to-date.

Comment 1 Volkmar W. Pogatzki 2024-05-09 09:15:06 UTC

Created attachment 892602 [details, diff]
allow_java-pkg-opt-2.patch proposed by Alfred Wingate on #gentoo-dev-help on 2024-04-25

Comment 2 Volkmar W. Pogatzki 2024-06-16 10:14:54 UTC

No need for touching the eclass.  It can be done like:

inherit java-pkg-opt-2 java-pkg-2 java-pkg-simple

Comment 3 Volkmar W. Pogatzki 2024-06-19 08:17:32 UTC

(In reply to Volkmar W. Pogatzki from comment #2)
> No need for touching the eclass.  It can be done like:
> 
> inherit java-pkg-opt-2 java-pkg-2 java-pkg-simple

That's wrong, sorry. Still fails with USE=-java

"Gentoo is about choice." -> java-pkg-simple.eclass should be about choice.

Comment 4 Larry the Git Cow gentoo-dev

2024-07-23 10:03:55 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bb707cd1f6b9ec3784789c71513657c02fdf1862

commit bb707cd1f6b9ec3784789c71513657c02fdf1862
Author:     Volkmar W. Pogatzki <gentoo@pogatzki.net>
AuthorDate: 2024-04-25 13:34:18 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2024-07-23 10:03:45 +0000

    java-pkg-simple.eclass: allow java-pkg-opt-2
    
    Presently, "java-pkg-simple eclass can only be inherited AFTER java-pkg-2".
    This prevents packages with optional Java like dev-lang/cxprolog to be
    built with java-pkg-simple. This patch allows to inherit java-pkg-simple
    after any of java-pkg-2 and java-pkg-opt-2.
    
    Poposed by Alfred Wingate on #gentoo-dev-help on 2024-04-25
    
    Closes: https://bugs.gentoo.org/930550
    Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>
    Closes: https://github.com/gentoo/gentoo/pull/37468/commits/6f27fbf4604d5504044a7eee3b765ce7efa83089
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 eclass/java-pkg-simple.eclass | 18 +++++++++++++++---
 1 file changed, 15 insertions(+), 3 deletions(-)