Bug 930336 – dev-libs/hiredis-1.2.0 adds -Werror flag on its own

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Agostino Sarubbo 2024-04-20 15:24:43 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-libs/hiredis-1.2.0 adds -Werror flag on its own.
Discovered on: amd64 (internal ref: ci)

Info about the issue:
https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#QA0035

[Comment 1 Agostino Sarubbo 2024-04-20 15:24:44 UTC]

Created attachment 891185 [details]
build.log

build log and emerge --info

[Comment 2 Larry the Git Cow 2024-04-20 21:34:05 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=07cf4f6acae4827766ff465039c4bcfbe0fcbbf2

commit 07cf4f6acae4827766ff465039c4bcfbe0fcbbf2
Author:     Petr Vaněk <[e-mail]>
AuthorDate: 2024-04-20 20:49:53 +0000
Commit:     Petr Vaněk <[e-mail]>
CommitDate: 2024-04-20 21:33:22 +0000

    dev-libs/hiredis: avoid default -Werror
    
    Upstream introduced unconditional addition of -Werror flag in
    hiredis-1.2.0 in commit [1]. This was changed to conditional addition
    controlled by USE_WERROR variable later in commit [2]. This change
    backports it in form of patch.
    
    Additionally, emake newly takes arguments from local myconf array.
    
    [1] https://github.com/redis/hiredis/commit/5cbd1f2960662c18b1d2b2dac7352f2b5b1ba776
    [2] https://github.com/redis/hiredis/commit/bff171c9fc83f8abed9a283a3da2dc91a5671419
    
    Closes: https://bugs.gentoo.org/930336
    Signed-off-by: Petr Vaněk <[e-mail]>

 .../files/hiredis-1.2.0-conditional-werror.patch   | 24 ++++++++++++++++++++++
 dev-libs/hiredis/hiredis-1.2.0.ebuild              | 23 ++++++++++++---------
 2 files changed, 37 insertions(+), 10 deletions(-)