Bug 929101

Summary:	net-misc/connman-json-client-1.0_p20150721-r2: crash if WiFi SSID contains unicode characters
Product:	Gentoo Linux	Reporter:	Andrii Batyiev <batyiev>
Component:	Current packages	Assignee:	Ben Kohler <bkohler>
Status:	CONFIRMED ---
Severity:	normal	CC:	batyiev, bkohler
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---

Description Andrii Batyiev 2024-04-10 19:59:27 UTC

net-misc/connman-json-client-1.0_p20150721-r2 uses ncurses by default, that does not support unicode. The particular problem is caused when function `renderers_services_wifi` (starts at renderers.c:627) calls function `new_item` (renderers.c:697). The `desc` variable contain unicode symbols and `new_item` (of regular ncurses) returns NULL.

Actual crash happens in `__renderers_free_services` during deallocation of invalid pointers.

WiFi standard says that SSID is a byte array up to 32 bytes, i.e. it can contain everything including unicode and null-terminators.

I think possible fix would be:
1. use ncursesw to actually display unicode
2. figure out why it display garbage instead of unicode <-- I'm here
3. figure out what to do with broken unicode (crash will probably persists)

Upstream is dead for 10 years.

Reproducible: Always

Steps to Reproduce:
1. Setup a WiFi AP with unicode SSID (I use OpenWRT as allows it; maybe some other AP will allow to input unicode SSID too)
2. Install net-misc/connman and net-misc/connman-json-client
3. Run connman_ncurses
4. Select WiFi "technology" on the "Technologies" list
5. Bug 1: Notice that you see only few SSIDs (some normal SSIDs will not be displayed too, because that come after unicode ones in the list)
6. Press ESCAPE keyboard button, or try to connect to AP (anything that will move away from that list).
7. Bug 2: Crash happens
Actual Results:  
Crash happens.

Expected Results:  
No crash happens.

Portage 3.0.61 (python 3.11.7-final-0, default/linux/amd64/17.0/x32, gcc-13, glibc-2.38-r10, 6.6.13-gentoo-x64 x86_64)                                                                                             
=================================================================                                                                                                                                                  
System uname: Linux-6.6.13-gentoo-x64-x86_64-Intel-R-_Core-TM-2_Duo_CPU_T5670_@_1.80GHz-with-glibc2.38                                                                                                             
KiB Mem:     2024908 total,   1429928 free                                                                                                                                                                         
KiB Swap:    8388596 total,   8328396 free
Timestamp of repository gentoo: Thu, 22 Feb 2024 18:00:00 +0000
Head commit of repository gentoo: a81d4c676e8f887299fcc65dd79b26d5cad21d84
sh bash 5.1_p16-r6
ld GNU ld (Gentoo 2.41 p5) 2.41.0
distcc 3.4 x86_64-pc-linux-gnux32 [disabled]
app-misc/pax-utils:        1.3.7::gentoo
app-shells/bash:           5.1_p16-r6::gentoo
dev-build/autoconf:        2.71-r6::gentoo
dev-build/automake:        1.16.5-r2::gentoo
dev-build/cmake:           3.27.9::gentoo
dev-build/libtool:         2.4.7-r2::gentoo
dev-build/make:            4.4.1-r1::gentoo
dev-build/meson:           1.3.1-r1::gentoo
dev-lang/perl:             5.38.2-r1::gentoo
dev-lang/python:           3.11.7::gentoo, 3.12.1_p1::gentoo
sys-apps/baselayout:       2.14-r2::gentoo
sys-apps/openrc:           0.53::gentoo
sys-apps/sandbox:          2.38::gentoo
sys-devel/binutils:        2.41-r5::gentoo
sys-devel/binutils-config: 5.5::gentoo
sys-devel/clang:           17.0.6::gentoo
sys-devel/gcc:             13.2.1_p20240113-r1::gentoo
sys-devel/gcc-config:      2.11::gentoo
sys-devel/llvm:            17.0.6::gentoo
sys-kernel/linux-headers:  6.6::gentoo (virtual/os-headers)
sys-libs/glibc:            2.38-r10::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    volatile: False
    sync-rsync-verify-jobs: 1
    sync-rsync-extra-opts: 
    sync-rsync-verify-metamanifest: yes
    sync-rsync-verify-max-age: 3

local
    location: /var/db/repos/local
    masters: gentoo
    volatile: False

Binary Repositories:

gentoobinhost
    priority: 1
    sync-uri: https://distfiles.gentoo.org/releases/amd64/binpackages/17.0/x32

ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnux32"
CFLAGS="-O2 -march=core2 -mtune=core2 -pipe -mmmx -msse -msse2 -msse3 -mssse3 -mcx16 -mfpmath=sse -msahf --param l1-cache-size=32 --param l1-cache-line-size=64 --param l2-cache-size=2048 -fno-stack-protector -flto"
CHOST="x86_64-pc-linux-gnux32"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -march=core2 -mtune=core2 -pipe -mmmx -msse -msse2 -msse3 -mssse3 -mcx16 -mfpmath=sse -msahf --param l1-cache-size=32 --param l1-cache-line-size=64 --param l2-cache-size=2048 -fno-stack-protector -flto"
DISTDIR="/var/cache/distfiles"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GDK_PIXBUF_MODULE_FILE GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR XDG_STATE_HOME"
FCFLAGS="-O2 -march=core2 -mtune=core2 -pipe -mmmx -msse -msse2 -msse3 -mssse3 -mcx16 -mfpmath=sse -msahf --param l1-cache-size=32 --param l1-cache-line-size=64 --param l2-cache-size=2048 -fno-stack-protector -flto"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance buildpkg-live config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox pkgdir-index-trusted preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms splitdebug strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -march=core2 -mtune=core2 -pipe -mmmx -msse -msse2 -msse3 -mssse3 -mcx16 -mfpmath=sse -msahf --param l1-cache-size=32 --param l1-cache-line-size=64 --param l2-cache-size=2048 -fno-stack-protector -flto"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="C.UTF8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LEX="flex"
LINGUAS="en uk"
MAKEOPTS="-j10 -l2"
PKGDIR="/var/cache/binpkgs"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
SHELL="/bin/bash"
USE="X acl alsa amd64 bzip2 cli crypt cyrillic dbus dri evdev flac fortran gdbm gpm graphite iconv icu ipv6 libdrm libtirpc lto lvm minizip mp3 mpg123 multilib ncurses nls ogg opengl openh264 openmp opus pam pcre qdbus qml qt6 readline seccomp sixel sndfile split-usr sqlite ssl test-rust theora truetype udev unicode v4l vorbis vpx wavpack xattr xinerama zlib" ABI_X86="x32" ADA_TARGET="gnat_2021" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_anon authn_dbm authn_file authz_dbm authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir env expires ext_filter file_cache filter headers include info log_config logio mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext sse sse2 sse3 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 ntrip navcom oceanserver oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 tsip tripmate tnt ublox" INPUT_DEVICES="evdev synaptics" KERNEL="linux" L10N="en uk" LCD_DEVICES="bayrad cfontz glk hd44780 lb216 lcdm001 mtxorb text" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php8-1" POSTGRES_TARGETS="postgres15" PYTHON_SINGLE_TARGET="python3_11" PYTHON_TARGETS="python3_11" RUBY_TARGETS="ruby31" VIDEO_CARDS="intel i965" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipp2p iface geoip fuzzy condition tarpit sysrq proto logmark ipmark dhcpmac delude chaos account"
Unset:  ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EMERGE_DEFAULT_OPTS, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LFLAGS, LIBTOOL, MAKE, MAKEFLAGS, NM, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, PYTHONPATH, RANLIB, READELF, RUSTFLAGS, SIZE, STRINGS, STRIP, YACC, YFLAGS

Comment 1 Ben Kohler gentoo-dev

2024-04-10 20:03:34 UTC

There is a fork of this, packaged as ncman-- can you test that and see if it fails the same way?

Thanks

Comment 2 Andrii Batyiev 2024-04-12 14:44:44 UTC

Unfortunately, ncman fails even before, i.e. it opens window "Error message: " with empty message when I select WiFi. It doesn't show any WiFi networks for me at all.