Bug 928969 – app-misc/ddcutil-2.1.4 adds -Werror flag on its own

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Agostino Sarubbo 2024-04-09 05:05:28 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: app-misc/ddcutil-2.1.4 adds -Werror flag on its own.
Discovered on: amd64 (internal ref: gcc14_tinderbox)
System: GCC-14-SYSTEM (https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#GCC-14)

Info about the issue:
https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#QA0035

[Comment 1 Agostino Sarubbo 2024-04-09 05:05:29 UTC]

Created attachment 889974 [details]
build.log

build log and emerge --info

[Comment 2 Larry the Git Cow 2025-02-26 06:14:01 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=60c04bf9dcaf6e03a4167524681b4abb0379122b

commit 60c04bf9dcaf6e03a4167524681b4abb0379122b
Author:     Z. Liu <[e-mail]>
AuthorDate: 2025-02-25 14:38:34 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2025-02-26 06:13:34 +0000

    app-misc/ddcutil: fix build error with clang 19
    
    1. 'test STRING' equivalent to '-n STRING' which is True if the length of
       string is non-zero, so 'test 0' always success. Both 'test ""' and
       'test 1 -eq 0' are ok, but the later is more intuitive.
    2. too many errors on Wcompound-token-split-by-macro, so disable this
       warning as a workaround.
    3. fix two errors reported by clang 19, patch submitted to upstream.
    
    Closes: https://bugs.gentoo.org/928969
    Closes: https://bugs.gentoo.org/929096
    Signed-off-by: Z. Liu <[e-mail]>
    Closes: https://github.com/gentoo/gentoo/pull/40762
    Signed-off-by: Sam James <[e-mail]>

 app-misc/ddcutil/ddcutil-2.1.4.ebuild              | 10 ++--
 .../ddcutil/files/ddcutil-1.4.1-no-werror.patch    |  2 +-
 .../ddcutil/files/ddcutil-2.1.4-fix-clang.patch    | 57 ++++++++++++++++++++++
 3 files changed, 65 insertions(+), 4 deletions(-)