Bug 928491

Summary:	x11-misc/rofi-file-browser-extended-1.3.1-r1 fails to compile: icons.c:52:57: error: passing argument 2 of g_array_steal from incompatible pointer type [-Wincompatible-pointer-types]
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Florian Schmaus <flow>
Status:	RESOLVED FIXED
Severity:	normal	Keywords:	PullRequest
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/36482 https://bugs.gentoo.org/show_bug.cgi?id=942654
Whiteboard:	fixed in 1.3.1-r2
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	870412, 941869
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2024-04-03 07:36:22 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: x11-misc/rofi-file-browser-extended-1.3.1-r1 fails to compile.
Discovered on: x86 (internal ref: tinderbox_x86)
System: GCC-14-SYSTEM (https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#GCC-14)

Info about the issue:
https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#CF0003

Comment 1 Agostino Sarubbo gentoo-dev

2024-04-03 07:36:23 UTC

Created attachment 889343 [details]
build.log

build log and emerge --info

Comment 2 Agostino Sarubbo gentoo-dev

2024-04-03 07:36:25 UTC

Error(s) that match a know pattern in addition to what has been reported in the summary:


FAILED: CMakeFiles/filebrowser.dir/src/icons.c.o 
/var/tmp/portage/x11-misc/rofi-file-browser-extended-1.3.1-r1/work/rofi-file-browser-extended-1.3.1/src/icons.c:52:57: error: passing argument 2 of ‘g_array_steal’ from incompatible pointer type [-Wincompatible-pointer-types]

Comment 3 Larry the Git Cow gentoo-dev

2024-10-25 07:06:40 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=26434e181c61eb73a3145a9da302170375dae3fe

commit 26434e181c61eb73a3145a9da302170375dae3fe
Author:     Brahmajit Das <brahmajit.xyz@gmail.com>
AuthorDate: 2024-04-30 06:15:24 +0000
Commit:     Florian Schmaus <flow@gentoo.org>
CommitDate: 2024-10-25 07:05:49 +0000

    x11-misc/rofi-file-browser-extended: Fix incompatible pointer type
    
    And some other build time warnings
    
    Closes: https://bugs.gentoo.org/928491
    Signed-off-by: Brahmajit Das <brahmajit.xyz@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/36482
    Signed-off-by: Florian Schmaus <flow@gentoo.org>

 ...rowser-extended-1.3.1-fix-gcc14-build-fix.patch | 53 ++++++++++++++++++++++
 .../rofi-file-browser-extended-1.3.1-r2.ebuild     | 48 ++++++++++++++++++++
 2 files changed, 101 insertions(+)