Bug 928090

Summary:	x11-libs/libgxim-0.5.0 fails to compile: gximcore.c:118:17: error: type of gdk_x11_atom_to_xatom_for_display does not match original declaration [-Werror=lto-type-mismatch]
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	CJK Team <cjk>
Status:	RESOLVED FIXED
Severity:	normal	CC:	eschwartz, zeekec
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://bugs.gentoo.org/show_bug.cgi?id=875056
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	618550
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2024-03-29 07:48:26 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: x11-libs/libgxim-0.5.0 fails to compile.
Discovered on: amd64 (internal ref: lto_tinderbox)
System: LTO-SYSTEM (https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#LTO)

Info about the issue:
https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#CF0014

Comment 1 Agostino Sarubbo gentoo-dev

2024-03-29 07:48:27 UTC

Created attachment 888963 [details]
build.log

build log and emerge --info

Comment 2 Eli Schwartz gentoo-dev

2024-07-10 01:43:59 UTC

This is actually "just" a GCC 14 implicit function declaration. But without that compile failure it had mismatched types due to incorrect implicit prototype...

Comment 3 Larry the Git Cow gentoo-dev

2024-07-10 15:24:44 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b1631392ca489e12652ed5682f2b79205b976c56

commit b1631392ca489e12652ed5682f2b79205b976c56
Author:     Eli Schwartz <eschwartz@gentoo.org>
AuthorDate: 2024-07-10 01:45:41 +0000
Commit:     Eli Schwartz <eschwartz@gentoo.org>
CommitDate: 2024-07-10 15:23:57 +0000

    x11-libs/libgxim: backport gcc 14 fix for implicit-function-decl
    
    Upstream has fixed this in 2018 but simply not released a new version:
    https://bitbucket.org/tagoh/libgxim/commits/274976ff39d9142169a18655f5013e66233ac9c8
    
    Due to the implicit function declaration, compilation fails on gcc 14.
    On gcc 13, instead, there is an lto-type-mismatch because the K&R C
    style incorrect prototype was... incorrect and mismatched the required
    types. :)
    
    The same upstream commit also includes an unrelated fix for a different
    build issue: -Werror=format-security.
    
    Closes: https://bugs.gentoo.org/875056
    Closes: https://bugs.gentoo.org/928090
    Signed-off-by: Eli Schwartz <eschwartz@gentoo.org>

 x11-libs/libgxim/files/libgxim-0.5.0-gcc14.patch   | 40 ++++++++++++++++++++++
 ...ibgxim-0.5.0.ebuild => libgxim-0.5.0-r1.ebuild} |  6 ++++
 2 files changed, 46 insertions(+)