Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 927482

Summary: sci-electronics/kicad-8.0.1 fails to compile: clipper.core.h:105:10: error: type struct Point violates the C++ One Definition Rule [-Werror=odr]
Product: Gentoo Linux Reporter: Agostino Sarubbo <ago>
Component: Current packagesAssignee: Zoltan Puskas <zoltan>
Status: RESOLVED FIXED    
Severity: normal CC: frej.drejhammar, kripton, proxy-maint, vowstar
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 618550    
Attachments: build.log.xz

Description Agostino Sarubbo gentoo-dev 2024-03-22 08:38:28 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sci-electronics/kicad-8.0.1 fails to compile.
Discovered on: amd64 (internal ref: lto_tinderbox)
System: LTO-SYSTEM (https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#LTO)

Info about the issue:
https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#CF0014
Comment 1 Agostino Sarubbo gentoo-dev 2024-03-22 08:38:29 UTC
Created attachment 888132 [details]
build.log.xz

build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)
Comment 2 Agostino Sarubbo gentoo-dev 2024-03-22 08:38:31 UTC
Error(s) that match a know pattern in addition to what has been reported in the summary:


FAILED: eeschema/_eeschema.kiface 
/var/tmp/portage/sci-electronics/kicad-8.0.1/work/kicad-8.0.1/thirdparty/clipper2/Clipper2Lib/include/clipper2/clipper.core.h:105:10: error: type ‘struct Point’ violates the C++ One Definition Rule [-Werror=odr]
Comment 3 Larry the Git Cow gentoo-dev 2024-05-03 12:51:33 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f1cce39266c87dd148a87b8deda5001e24a4e1c1

commit f1cce39266c87dd148a87b8deda5001e24a4e1c1
Author:     Andrew Ammerlaan <andrewammerlaan@gentoo.org>
AuthorDate: 2024-05-03 12:46:22 +0000
Commit:     Andrew Ammerlaan <andrewammerlaan@gentoo.org>
CommitDate: 2024-05-03 12:51:08 +0000

    sci-electronics/kicad: add 8.0.2
    
    - compat with occt 8.0.2
    - fix finding libs in tests
    - filter-lto
    - add missing dep on wxGTK[wayland]
    - drop USE=telemetry, this now requires configureing DSN at build time,
            upstream default is off, other distro's do not enable this,
            unclear what the DSN should be if enabled.
    
    Closes: https://bugs.gentoo.org/923351
    Closes: https://bugs.gentoo.org/927226
    Closes: https://bugs.gentoo.org/927482
    Closes: https://bugs.gentoo.org/927952
    Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>

 sci-electronics/kicad/Manifest           |   1 +
 sci-electronics/kicad/kicad-8.0.2.ebuild | 180 +++++++++++++++++++++++++++++++
 sci-electronics/kicad/kicad-9999.ebuild  |  16 +--
 3 files changed, 191 insertions(+), 6 deletions(-)
Comment 4 Frej Drejhammar 2024-05-04 13:00:36 UTC
>     - add missing dep on wxGTK[wayland]

I'm sorry but I don't think this is the right solution. Forcing users to pull in Wayland to fix an LTO problem doesn't feel right to me. Especially as on a (non LTO) system where -wayland is set globally, Kicad builds perfectly fine if the dependency is >=x11-libs/wxGTK-3.2.2.1-r3:${WX_GTK_VER}[X,opengl].

Perhaps x11-libs/gtk+[wayland] should force x11-libs/wxGTK[wayland] but that's a pure guess and how to express that is way outside my ebuild-fu.
Comment 5 Frej Drejhammar 2024-05-04 13:07:51 UTC
(In reply to Frej Drejhammar from comment #4)

Sorry wrong bug, I intended this to go to https://bugs.gentoo.org/927952