Bug 927258

Summary:	sys-apps/util-linux ABI changes between 2.38 and 2.39, affecting net-fs/nfs-utils?
Product:	Gentoo Linux	Reporter:	Matt Turner <mattst88>
Component:	Current packages	Assignee:	Gentoo's Team for Core System packages <base-system>
Status:	RESOLVED FIXED
Severity:	normal	Keywords:	PATCH
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	https://github.com/util-linux/util-linux/issues/2844
Whiteboard:
Package list:		Runtime testing required:	---

Description Matt Turner gentoo-dev

2024-03-19 01:24:37 UTC

I noticed this in `journalctl` after updating util-linux from 2.38.1-r3 to 2.39.3-r2:

> Mar 04 14:22:11 framework umount[1096669]: /sbin/umount.nfs4: symbol lookup error: /sbin/umount.nfs4: undefined symbol: mnt_context_is_lazy, version MOUNT_2.19

With util-linux-2.38.1-r3:

> $ nm -DCg /usr/lib64/libmount.so.1.1.0 | grep mnt_context_is_lazy
> 000000000001ad30 T mnt_context_is_lazy@@MOUNT_2.19

With util-linux-2.39.3-r2:

> $ nm -DCg /usr/lib64/libmount.so.1.1.0 | grep mnt_context_is_lazy
> 00000000000296c0 T mnt_context_is_lazy@@MOUNT_2_39

The commit that made this change upstream is https://github.com/util-linux/util-linux/commit/3d1c41c8cff0872d5ee6db8e9ba152ab8eb67e03 and it looks odd to me.

It added two functions:

> mnt_context_enable_onlyonce
> mnt_context_is_onlyonce

But it added

> mnt_context_enable_onlyonce
> mnt_context_is_lazy

to `libmount/src/libmount.sym` and the comment above the definition of `mnt_context_is_onlyonce` says `mnt_context_is_lazy`. Are these copy-and-paste mistakes...?

Comment 1 Sam James archtester

2024-03-20 16:30:17 UTC

Feel free to pull in the fix, or one of us can later.

Comment 2 Larry the Git Cow gentoo-dev

2024-03-22 00:12:23 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8b47f3e31e88331b75c8108ea827b78118b0fe70

commit 8b47f3e31e88331b75c8108ea827b78118b0fe70
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2024-03-22 00:10:11 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2024-03-22 00:12:15 +0000

    sys-apps/util-linux: Fix export of mnt_context_is_lazy
    
    Closes: https://bugs.gentoo.org/927258
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 ...x-export-of-mnt_context_is_lazy-and-mnt_c.patch |  55 +++
 sys-apps/util-linux/util-linux-2.39.3-r5.ebuild    | 414 +++++++++++++++++++++
 2 files changed, 469 insertions(+)