Bug 927033

Summary:	phosh-base/phosh-shell-0.36 inherently activates systemd
Product:	GURU	Reporter:	Xeha <Xeha>
Component:	Package issues	Assignee:	gjdijkman
Status:	RESOLVED FIXED
Severity:	normal	CC:	cyber+gentoo, Xeha
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	patch for systemd/openrc via use flag

Description Xeha 2024-03-14 20:08:31 UTC

In the meson config for this package, systemd is always enabled and dosnt repsect use flags.
This cause gnome-session to pass --systemd, which failed to spawn the shell since its a unknown argument.

Reproducible: Always

Steps to Reproduce:
1. build phosh-base/phosh-shell-0.36 without systemd
2. login via gdm into phosh
3. session crashes, logs show that --systemd is a unknown argument
Actual Results:  
the session crashes

Expected Results:  
the session starts successfully

Comment 1 Xeha 2024-03-14 20:10:23 UTC

Created attachment 887653 [details, diff]
patch for systemd/openrc via use flag

Comment 2 Xeha 2024-03-14 20:11:03 UTC

With the patch, this works now on a openrc profile too and will continue to work on systemd profiles as well.

Comment 3 Anna Vyalkova 2024-04-08 21:29:29 UTC

This could stop working with >=gnome-session-46.0

https://gitlab.gnome.org/World/Phosh/phosh/-/commit/6c18fb28f9fd535c511c8a6f3b749e31b72a7c17

Comment 4 Larry the Git Cow gentoo-dev

2024-04-09 11:25:20 UTC

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=603c48d2625bc05c051bd76d37e667db0b9ff6d0

commit 603c48d2625bc05c051bd76d37e667db0b9ff6d0
Author:     Anna (cybertailor) Vyalkova <cyber+gentoo@sysrq.in>
AuthorDate: 2024-04-09 02:34:39 +0000
Commit:     Anna (cybertailor) Vyalkova <cyber+gentoo@sysrq.in>
CommitDate: 2024-04-09 03:27:58 +0000

    phosh-base/phosh-shell: add 0.38.0
    
    Bug: https://bugs.gentoo.org/927033
    Signed-off-by: Anna (cybertailor) Vyalkova <cyber+gentoo@sysrq.in>

 phosh-base/phosh-shell/Manifest                  |   2 +
 phosh-base/phosh-shell/phosh-shell-0.36.0.ebuild |   4 +-
 phosh-base/phosh-shell/phosh-shell-0.38.0.ebuild | 138 +++++++++++++++++++++++
 3 files changed, 142 insertions(+), 2 deletions(-)

Comment 5 Larry the Git Cow gentoo-dev

2024-07-01 13:50:20 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=de47213e7665ba4129b5432a7d0ad386acaad480

commit de47213e7665ba4129b5432a7d0ad386acaad480
Author:     Anna (cybertailor) Vyalkova <cyber+gentoo@sysrq.in>
AuthorDate: 2024-06-30 08:30:24 +0000
Commit:     Anna (cybertailor) Vyalkova <cyber+gentoo@sysrq.in>
CommitDate: 2024-06-30 08:30:24 +0000

    phosh-base/phosh-shell: add 0.40.0
    
    Closes: https://bugs.gentoo.org/933129
    Closes: https://bugs.gentoo.org/927033
    Closes: https://bugs.gentoo.org/928366
    Signed-off-by: Anna (cybertailor) Vyalkova <cyber+gentoo@sysrq.in>

 phosh-base/phosh-shell/Manifest                  |   2 +
 phosh-base/phosh-shell/phosh-shell-0.40.0.ebuild | 145 +++++++++++++++++++++++
 2 files changed, 147 insertions(+)