Summary: | net-vpn/tor-0.4.8.10: fails tests with sys-devel/gcc-14 and -O2 -mavx -fno-vect-cost-model | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Sam James <sam> |
Component: | Current packages | Assignee: | Gentoo Toolchain Maintainers <toolchain> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | ajak, sam |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114339 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 914580 |
Description
Sam James
2024-03-14 09:51:45 UTC
* -O2 -mavx -fno-vect-cost-model is enough * src/test/test --verbose entrynodes/node_filter --no-fork lets us get the proper crash rather than the test driver Program received signal SIGABRT, Aborted. 0x00007ffff7489cdc in ?? () from /usr/lib64/libc.so.6 (gdb) bt #0 0x00007ffff7489cdc in ?? () from /usr/lib64/libc.so.6 #1 0x00007ffff7434032 in raise () from /usr/lib64/libc.so.6 #2 0x00007ffff741c4f2 in abort () from /usr/lib64/libc.so.6 #3 0x0000555555b39010 in tor_raw_abort_ () at src/lib/err/torerr.c:225 #4 0x0000555555b46e30 in tor_abort_ () at src/lib/log/util_bug.c:174 #5 0x0000555555a0fcde in get_retry_schedule (failing_since=<optimized out>, now=1710410426, is_primary=<optimized out>) at src/feature/client/entrynodes.c:2072 #6 entry_guard_consider_retry (guard=guard@entry=0x555555e6be60) at src/feature/client/entrynodes.c:2089 #7 0x0000555555a0fff0 in entry_guard_consider_retry (guard=0x555555e6be60) at src/feature/client/entrynodes.c:2084 #8 entry_guard_set_filtered_flags (options=options@entry=0x555555e1a4b0, gs=gs@entry=0x555555e6b500, guard=0x555555e6be60) at src/feature/client/entrynodes.c:1737 #9 0x0000555555a118aa in entry_guards_update_filtered_sets (gs=gs@entry=0x555555e6b500) at src/feature/client/entrynodes.c:1758 #10 0x00005555557cded7 in test_entry_guard_node_filter (arg=<optimized out>) at src/test/test_entrynodes.c:1037 #11 0x000055555599ece5 in testcase_run_bare_ (testcase=testcase@entry=0x555555da13d8 <entrynodes_tests+760>) at src/ext/tinytest.c:107 #12 0x000055555599edb3 in testcase_run_one (group=group@entry=0x555555d99380 <testgroups+864>, testcase=0x555555da13d8 <entrynodes_tests+760>) at src/ext/tinytest.c:272 #13 0x000055555599f60c in tinytest_main (c=c@entry=4, v=v@entry=0x7fffffffd928, groups=groups@entry=0x555555d99020 <testgroups>) at src/ext/tinytest.c:454 #14 0x00005555555eb47b in main (c=4, v=<optimized out>) at src/test/testing_common.c:424 (gdb) The assert is at https://gitlab.torproject.org/tpo/core/tor/-/blob/tor-0.4.8.10/src/feature/client/entrynodes.c#L2072 ``` (gdb) p delays $3 = {{ maximum = 21600, primary_delay = 600, nonprimary_delay = 3600 }, { maximum = 345600, primary_delay = 5400, nonprimary_delay = 14400 }, { maximum = 604800, primary_delay = 14400, nonprimary_delay = 64800 }, { maximum = 9223372036854775807, primary_delay = 32400, nonprimary_delay = 129600 }} (gdb) ``` The bad loop is: for (i = 0; i < ARRAY_LENGTH(delays); ++i) { if (tdiff <= delays[i].maximum) { return is_primary ? delays[i].primary_delay : delays[i].nonprimary_delay; } } Got a reproducer and ran cvise on it while slept. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=da6dcbbd28d6482e45d726d2ade0a5c301c1e500 commit da6dcbbd28d6482e45d726d2ade0a5c301c1e500 Author: Sam James <sam@gentoo.org> AuthorDate: 2024-03-18 04:44:19 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-03-18 04:44:19 +0000 sys-devel/gcc: add 14.0.1_pre20240317 Closes: https://bugs.gentoo.org/920233 Closes: https://bugs.gentoo.org/925873 Closes: https://bugs.gentoo.org/927013 Signed-off-by: Sam James <sam@gentoo.org> sys-devel/gcc/Manifest | 1 + sys-devel/gcc/gcc-14.0.1_pre20240317.ebuild | 65 +++++++++++++++++++++++++++++ 2 files changed, 66 insertions(+) |