Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 926648

Summary: sys-libs/libseccomp-2.5.5-r1 fails tests: FAIL: regression
Product: Gentoo Linux Reporter: Agostino Sarubbo <ago>
Component: Current packagesAssignee: Gentoo's Team for Core System packages <base-system>
Status: RESOLVED FIXED    
Severity: normal Keywords: PATCH, PullRequest, TESTFAILURE
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/gentoo/gentoo/pull/36273
https://github.com/seccomp/libseccomp/pull/425
https://github.com/seccomp/libseccomp/pull/433
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 915000    
Attachments: build.log

Description Agostino Sarubbo gentoo-dev 2024-03-10 08:09:42 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sys-libs/libseccomp-2.5.5-r1 fails tests.
Discovered on: amd64 (internal ref: clang-lld_tinderbox)
System: CLANG-LLD (https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#CLANG-LLD)

Info about the issue:
https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#CF0015
Comment 1 Agostino Sarubbo gentoo-dev 2024-03-10 08:09:44 UTC
Created attachment 887229 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2024-03-10 08:09:45 UTC
Error(s) that match a know pattern in addition to what has been reported in the summary:


FAIL: regression
grep: ../include/seccomp-syscalls.h: No such file or directory
tail: cannot open './syscalls.csv' for reading: No such file or directory
Comment 3 Larry the Git Cow gentoo-dev 2024-04-13 17:11:08 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d58730757b79ce429d5fbe8f35dede6074d4c243

commit d58730757b79ce429d5fbe8f35dede6074d4c243
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2024-04-13 17:05:00 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2024-04-13 17:10:47 +0000

    sys-libs/libseccomp: backport fix for arch-syscall-check
    
    Bug: https://bugs.gentoo.org/926648
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 .../libseccomp-2.5.5-arch-syscall-check.patch      | 45 ++++++++++++++++++++++
 sys-libs/libseccomp/libseccomp-2.5.5-r1.ebuild     |  1 +
 2 files changed, 46 insertions(+)
Comment 4 Mike Gilbert gentoo-dev 2024-04-13 17:19:29 UTC
I am unable to reproduce the "regression" test failure. I suspect it is caused by something specific to the tinderbox environment.

Does the tinderbox run with its own set of seccomp filters? This might be implemented by a container manager or something like that.
Comment 5 Agostino Sarubbo gentoo-dev 2024-04-14 06:03:53 UTC
there are no filters here. However I reproduced the issue only with clang+lld
Comment 6 Larry the Git Cow gentoo-dev 2024-04-17 19:47:36 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a65ce7b0b71668fb49b960d7259b36eba6ab34cc

commit a65ce7b0b71668fb49b960d7259b36eba6ab34cc
Author:     Matoro Mahri <matoro_gentoo@matoro.tk>
AuthorDate: 2024-04-15 23:04:59 +0000
Commit:     WANG Xuerui <xen0n@gentoo.org>
CommitDate: 2024-04-17 19:45:21 +0000

    sys-libs/libseccomp: rebase experimental-loong patches
    
    The fix backported in d58730757b79ce429d5fbe8f35dede6074d4c243 was
    already in the loong tree which makes the patch fail to apply.  Rebase
    this and also now rather than having a huge patch that doesn't
    correspond to VCS with a bunch of checked-in autotools stuff, use the
    github diff and eautoreconf for 9999 and loong.
    
    Fixes: d58730757b79 ("sys-libs/libseccomp: backport fix for arch-syscall-check")
    Bug: https://bugs.gentoo.org/926648
    Signed-off-by: Matoro Mahri <matoro_gentoo@matoro.tk>
    Signed-off-by: WANG Xuerui <xen0n@gentoo.org>

 sys-libs/libseccomp/Manifest                   |  1 +
 sys-libs/libseccomp/libseccomp-2.5.5-r1.ebuild | 18 +++++++++++++-----
 2 files changed, 14 insertions(+), 5 deletions(-)
Comment 7 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-10-06 14:58:58 UTC
(In reply to Agostino Sarubbo from comment #5)
> there are no filters here. However I reproduced the issue only with clang+lld

It's an aliasing bug.
Comment 8 Larry the Git Cow gentoo-dev 2024-10-07 02:40:05 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=00b81b84504c9de0c8bc7c9c9071afaf80cc6042

commit 00b81b84504c9de0c8bc7c9c9071afaf80cc6042
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-10-06 14:59:25 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-10-07 02:39:24 +0000

    sys-libs/libseccomp: backport aliasing fix
    
    I thought I'd backported this already, sorry.
    
    Closes: https://bugs.gentoo.org/926648
    Signed-off-by: Sam James <sam@gentoo.org>

 .../files/libseccomp-2.5.5-aliasing.patch          |  30 +++++
 sys-libs/libseccomp/libseccomp-2.5.5-r2.ebuild     | 127 +++++++++++++++++++++
 2 files changed, 157 insertions(+)