Bug 926320 – kde-apps/kfloppy-23.04.3 fails to compile: format.h:176:7: error: type struct FloppyAction violates the C++ One Definition Rule [-Werror=odr]

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Agostino Sarubbo 2024-03-07 08:02:37 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: kde-apps/kfloppy-23.04.3 fails to compile.
Discovered on: amd64 (internal ref: lto_tinderbox)
System: LTO-SYSTEM (https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#LTO)

Info about the issue:
https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#CF0014

[Comment 1 Agostino Sarubbo 2024-03-07 08:02:38 UTC]

Created attachment 886861 [details]
build.log

build log and emerge --info

[Comment 2 Agostino Sarubbo 2024-03-07 08:02:40 UTC]

Error(s) that match a know pattern in addition to what has been reported in the summary:


FAILED: bin/kfloppy 
/var/tmp/portage/kde-apps/kfloppy-23.04.3/work/kfloppy-23.04.3_build/kfloppy_autogen/EWIEGA46WW/../../../kfloppy-23.04.3/format.h:176:7: error: type ‘struct FloppyAction’ violates the C++ One Definition Rule [-Werror=odr]

[Comment 3 Larry the Git Cow 2024-05-09 01:31:27 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e9d9fffdbcbf521f680dc64851b055c50ac70fd8

commit e9d9fffdbcbf521f680dc64851b055c50ac70fd8
Author:     Eli Schwartz <[e-mail]>
AuthorDate: 2024-05-09 01:26:46 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2024-05-09 01:30:00 +0000

    kde-apps/kfloppy: mark as LTO-unsafe
    
    I submitted an upstream patch to fix it, but not importing it here since
    it isn't merged yet.
    
    Closes: https://bugs.gentoo.org/926320
    Signed-off-by: Eli Schwartz <[e-mail]>
    Signed-off-by: Sam James <[e-mail]>

 kde-apps/kfloppy/kfloppy-23.04.3.ebuild | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

[Comment 4 Larry the Git Cow 2024-05-09 01:35:52 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=8f2601e3633f4e5f2c0ac4a5f6fad49b70759c04

commit 8f2601e3633f4e5f2c0ac4a5f6fad49b70759c04
Author:     Eli Schwartz <[e-mail]>
AuthorDate: 2024-05-09 01:26:46 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2024-05-09 01:35:06 +0000

    kde-apps/kfloppy: mark as LTO-unsafe
    
    I submitted an upstream patch to fix it, but not importing it here since
    it isn't merged yet.
    
    Closes: https://bugs.gentoo.org/926320
    Signed-off-by: Eli Schwartz <[e-mail]>
    Signed-off-by: Sam James <[e-mail]>

 kde-apps/kfloppy/kfloppy-9999.ebuild | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

[Comment 5 Larry the Git Cow 2024-05-09 01:36:38 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7b259b70b9ff95b8cde4a800b59c9e952295fae0

commit 7b259b70b9ff95b8cde4a800b59c9e952295fae0
Author:     Sam James <[e-mail]>
AuthorDate: 2024-05-09 01:36:14 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2024-05-09 01:36:21 +0000

    kde-apps/kfloppy: cmake -> ecm
    
    Bug: https://bugs.gentoo.org/926320
    Signed-off-by: Sam James <[e-mail]>

 kde-apps/kfloppy/kfloppy-23.04.3.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)