Summary: | net-misc/minidlna branding, lto IUSE addition | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | David Carlos Manuelda <StormByte> |
Component: | Current packages | Assignee: | Michał Górny <mgorny> |
Status: | UNCONFIRMED --- | ||
Severity: | minor | CC: | eschwartz93, StormByte |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | minidlna-1.3.3-r1.ebuild |
Description
David Carlos Manuelda
2024-03-04 11:52:58 UTC
Aditionally, LTO is supported conditionally into its configure script so it can be added as another IUSE. Created attachment 886710 [details]
minidlna-1.3.3-r1.ebuild
Proposed ebuild with changes:
* Conditionally download and apply branding patch
* Conditionally enable LTO based on IUSE
* Clean empty test function
Gentoo recently removed all IUSE for lto, the general recommendation now is to rely on enabling LTO via *FLAGS inside make.conf. In cases where the build system needs to take specific care when enabling LTO, you can use tc-is-lto to detect whether the user has enabled LTO, and filter-lto to force LTO off. In this case specifically it looks like the --enable-lto flag just decides whether to update: CFLAGS="$CFLAGS -flto" so I think the best course of action here is to do nothing. (In reply to Eli Schwartz from comment #3) > Gentoo recently removed all IUSE for lto, the general recommendation now is > to rely on enabling LTO via *FLAGS inside make.conf. > > In cases where the build system needs to take specific care when enabling > LTO, you can use tc-is-lto to detect whether the user has enabled LTO, and > filter-lto to force LTO off. > > In this case specifically it looks like the --enable-lto flag just decides > whether to update: > > CFLAGS="$CFLAGS -flto" > > so I think the best course of action here is to do nothing. Thanks for the hint! So what about the other branding IUSE proposal? |