Bug 926129 – net-libs/libisds-0.11.1-r1 fails to compile: service.c:71:9: error: call to undeclared library function free with type void (void ); ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Agostino Sarubbo 2024-03-04 08:35:22 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: net-libs/libisds-0.11.1-r1 fails to compile.
Discovered on: amd64 (internal ref: clang-lld_tinderbox)
System: CLANG-LLD (https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#CLANG-LLD)

Info about the issue:
https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#CF0002

[Comment 1 Agostino Sarubbo 2024-03-04 08:35:24 UTC]

Created attachment 886645 [details]
build.log

build log and emerge --info

[Comment 2 Petr Pisar 2024-03-09 19:07:40 UTC]

Thanks for the notification. This observed bug was triggered by upgrading dev-libs/libxml to >= 2.12.0. A fix already exists in the upstream developmental tree (commit 0539e12b3de14a77481bd3f87b301b7e7550172c). I will let upstream to do a new release and then add it to the portage.

[Comment 3 Sam James 2024-03-10 02:21:18 UTC]

I'd consider backporting it as it's broken in stable, if the patch is not too big.

[Comment 4 Petr Pisar 2024-03-10 20:08:17 UTC]

Created attachment 887274 [details, diff]
net-libs/libisds-0.11.1-r2

This patch to gentoo tree adds net-libs/libisds-0.11.1-r2 which applies upstream's fix for his bug report.

I verified it with "CFLAGS='-Werror=implicit-function-declaration' USE=test emerge -v1a =net-libs/libisds-0.11.1-r2" command.

[Comment 5 Sam James 2024-03-12 02:22:40 UTC]

Thanks. I've also added the patch from bug 836628.

It's easy to miss patches attached on bz - feel free to make PRs at github.com/gentoo/gentoo or mail patches to the proxy maint ML.

[Comment 6 Larry the Git Cow 2024-03-12 02:23:30 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4c2e6a53475e49ef74dab3875af5387c2218f580

commit 4c2e6a53475e49ef74dab3875af5387c2218f580
Author:     Petr Písař <[e-mail]>
AuthorDate: 2024-03-10 19:53:29 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2024-03-12 02:23:01 +0000

    net-libs/libisds: Fix building with >=dev-libs/libxml-2.12.0
    
    A fix ported from upstream:
    
        commit 0539e12b3de14a77481bd3f87b301b7e7550172c (HEAD -> master, repo.or.cz/master)
        Author: Petr Písař <[e-mail]>
        Date:   Thu Nov 23 21:10:05 2023 +0100
    
            Fix building with libxml2-2.12.0
    
            libxml-2.12.0 shuffled included header files.
    
    Closes: https://bugs.gentoo.org/926129
    Signed-off-by: Petr Písař <[e-mail]>
    Signed-off-by: Sam James <[e-mail]>

 ...s-0.11.1-Fix-building-with-libxml2-2.12.0.patch | 37 ++++++++++++++
 net-libs/libisds/libisds-0.11.1-r2.ebuild          | 59 ++++++++++++++++++++++
 2 files changed, 96 insertions(+)