Bug 926121

Summary:	cmake.eclass: pass -DCMAKE_COMPILE_WARNING_AS_ERROR=OFF
Product:	Gentoo Linux	Reporter:	Sam James <sam>
Component:	Eclasses	Assignee:	Gentoo's Team for Core System packages <base-system>
Status:	RESOLVED FIXED
Severity:	normal	CC:	kde
Priority:	Normal	Keywords:	PullRequest
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/38159
Whiteboard:
Package list:		Runtime testing required:	---

Description Sam James archtester

2024-03-04 04:39:51 UTC

By policy in Gentoo, we disable -Werror (https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html#-werror-compiler-flag-not-removed).

CMake 3.24 has a new option to control this: https://cmake.org/cmake/help/latest/prop_tgt/COMPILE_WARNING_AS_ERROR.html.

We should set -DCMAKE_COMPILE_WARNING_AS_ERROR=OFF in cmake.eclass.

(Noticed this because of https://github.com/mariadb-corporation/mariadb-connector-c/commit/395641549ac72bc31def6d8b64e09093336aef72).

Comment 1 Larry the Git Cow gentoo-dev

2024-06-27 17:39:00 UTC

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=4ec823b93a188a56cf5adaacd92a39c224b1fa08

commit 4ec823b93a188a56cf5adaacd92a39c224b1fa08
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2024-06-24 20:59:33 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2024-06-27 16:48:44 +0000

    cmake.eclass: Set CMAKE_COMPILE_WARNING_AS_ERROR=OFF
    
    Bug: https://bugs.gentoo.org/926121
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 eclass/cmake.eclass | 1 +
 1 file changed, 1 insertion(+)

Comment 2 Larry the Git Cow gentoo-dev

2024-08-15 17:48:05 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=689be1a4afcc8222f7d10f822789d2e1676d0829

commit 689be1a4afcc8222f7d10f822789d2e1676d0829
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2024-06-24 20:59:33 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2024-08-15 17:46:44 +0000

    cmake.eclass: Set CMAKE_COMPILE_WARNING_AS_ERROR=OFF
    
    Closes: https://bugs.gentoo.org/926121
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 eclass/cmake.eclass | 1 +
 1 file changed, 1 insertion(+)