Summary: | app-portage/nattka-0.4.1-r1: make-package-list command crashes without git checkout | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | A Schenck <galiven> |
Component: | Current packages | Assignee: | Michał Górny <mgorny> |
Status: | RESOLVED INVALID | ||
Severity: | enhancement | CC: | galiven |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | Patch to remove git dependency for 'make-package-list' command |
Description
A Schenck
2024-03-03 01:42:31 UTC
Per /usr/lib/python3.11/site-packages/nattka/git.py, it needs a git repo to be able to reset the state after, I think? (In reply to Sam James from comment #1) > Per /usr/lib/python3.11/site-packages/nattka/git.py, it needs a git repo to > be able to reset the state after, I think? Ahh, so it is actually a destructive action because it defers to pkgcheck to do the scanning and that requires the ebuild(s) to be updated on disk. That is unfortunate but makes a bit of sense. For this one command the only writes seem to come from keyword.update_keywords_in_file which could return the original content if it changed, and an alternate context manager implementation could write that back. But that would be more work and be much more likely to closed "won't fix". Syncing from rsync keeps a clean original copy to verify the manifest before writing the updates to the repository, which would be a reasonable approach here but it's taking a while to read the sync code to see how that works. Or the changed ebuilds could be written to an overlay instead of over the existing files if pkgcheck supports overlays. So many options but they require time to look into. |