Bug 926051

Summary:	games-board/freedoko-0.7.16-r1 fails to compile: trick_drawing.h:47:7: error: type struct TrickDrawing violates the C++ One Definition Rule [-Werror=odr]
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Gentoo Games <games>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	618550
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2024-03-02 20:42:58 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: games-board/freedoko-0.7.16-r1 fails to compile.
Discovered on: amd64 (internal ref: lto_tinderbox)
System: LTO-SYSTEM (https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#LTO)

Info about the issue:
https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#CF0014

Comment 1 Agostino Sarubbo gentoo-dev

2024-03-02 20:42:59 UTC

Created attachment 886554 [details]
build.log

build log and emerge --info

Comment 2 Larry the Git Cow gentoo-dev

2024-03-22 05:33:19 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=405073029c1ae4a1a2a1a2cbfb7d5af0284c12f1

commit 405073029c1ae4a1a2a1a2cbfb7d5af0284c12f1
Author:     Eli Schwartz <eschwartz93@gmail.com>
AuthorDate: 2024-03-22 04:00:17 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-03-22 05:31:55 +0000

    games-board/freedoko: add 0.8.0
    
    Brings us up from 2017 to end of 2023. Drop hack for CXX std as it was
    introduced in commit 91ecddb6c84583bc2839b5b510629880a763a045 for the
    purpose of "Fix building with latest glibmm/libsigc++" and it seems
    quite archaic as a temporary hotfix.
    
    Reroll the patch, drop 2 data directories that were dropped upstream.
    
    The new version handily fixes compiling with LTO.
    
    Closes: https://bugs.gentoo.org/926051
    Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 games-board/freedoko/Manifest                      |  1 +
 .../freedoko/files/freedoko-0.8.0-gentoo.patch     | 34 ++++++++
 games-board/freedoko/freedoko-0.8.0.ebuild         | 97 ++++++++++++++++++++++
 3 files changed, 132 insertions(+)