Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 925557

Summary: app-crypt/pinentry-1.2.1: Bad #include / implicit declaration of function ‘secmem_free’
Product: Gentoo Linux Reporter: Suvi Adams <gentoo>
Component: Current packagesAssignee: Gentoo's Team for Core System packages <base-system>
Status: RESOLVED FIXED    
Severity: normal CC: gentoo
Priority: Normal Keywords: PATCH
Version: unspecified   
Hardware: AMD64   
OS: Linux   
URL: https://dev.gnupg.org/D566
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: build.log
8ab1682e80a2b4185ee9ef66cbb44340245966fc backport

Description Suvi Adams 2024-02-26 19:55:57 UTC 
Because of the order of the -I flags passed to the compiler, pinentry may pull in <memory.h> instead of "secmem/memory.h" in certain circumstances. This issue was fixed upstream in 8ab1682e80a2b4185ee9ef66cbb44340245966fc, but there hasn't been a release since that commit was introduced.

I've extracted that patch and am attaching it to this report for anybody having a similar compilation failure to this.

Reproducible: Always

Steps to Reproduce:
1. Set EPREFIX to an empty directory.
2. Run emerge -1nND app-crypt/pinentry
Actual Results:  
The build failed.

Expected Results:  
The build should have succeeded.

Portage 3.0.61 (python 3.11.7-final-0, default/linux/amd64/17.1, gcc-13, unavailable, 6.1.53-hydrogen-r1-x86_64 x86_64)
=================================================================
System uname: Linux-6.1.53-hydrogen-r1-x86_64-x86_64-Intel-R-_Xeon-R-_CPU_E5-2660_v3_@_2.60GHz-with-glibc2.38
KiB Mem:   264018764 total, 130712064 free
KiB Swap:          0 total,         0 free
Timestamp of repository gentoo: Thu, 22 Feb 2024 00:45:00 +0000
Head commit of repository wolfbun: b5718eccedbe3ff2fa18323defee51f5e379f483

sh bash 5.1_p16-r6
ld GNU ld (Gentoo 2.41 p4) 2.41.0
dev-build/make:            4.4.1-r1::gentoo
sys-apps/baselayout:       2.14-r2::gentoo
sys-devel/binutils-config: 5.5::gentoo
sys-devel/gcc-config:      2.11::gentoo
sys-kernel/linux-headers:  6.6::gentoo (virtual/os-headers)
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-openpgp-key-refresh: no
    sync-type: webrsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    volatile: False
    sync-webrsync-verify-signature: no

wolfbun
    location: /var/db/repos/wolfbun
    sync-type: git
    sync-uri: /root/wolfbun
    masters: gentoo
    volatile: False

crossdev
    location: /var/db/repos/crossdev
    masters: gentoo
    priority: 10
    volatile: False

ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=sandybridge -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc"
CONFIG_PROTECT_MASK="/etc/env.d /etc/gconf /etc/gentoo-release /etc/terminfo"
CXXFLAGS="-march=sandybridge -O2 -pipe"
DISTDIR="/var/cache/distfiles"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GDK_PIXBUF_MODULE_FILE GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR XDG_STATE_HOME"
FCFLAGS="-march=sandybridge -O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance buildpkg-live config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync mount-sandbox multilib-strict network-sandbox news parallel-fetch pid-sandbox pkgdir-index-trusted preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-march=sandybridge -O2 -pipe"
# GENTOO_MIRRORS was omitted from this section because I'm too new to post URLs.
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LEX="flex"
MAKEOPTS="-j41"
PKGDIR="/var/cache/binpkgs"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
SHELL="/bin/bash"
USE="X acl amd64 bzip2 cli crypt dri fortran gdbm iconv ipv6 libtirpc lvm multilib ncurses nls openmp pam pcre readline seccomp split-usr ssl test-rust unicode xattr zlib" ABI_X86="64 32" ADA_TARGET="gnat_2021" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_anon authn_dbm authn_file authz_dbm authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir env expires ext_filter file_cache filter headers include info log_config logio mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext sse sse2" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 ntrip navcom oceanserver oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 tsip tripmate tnt ublox" GRUB_PLATFORMS="efi-64" INPUT_DEVICES="libinput" KERNEL="linux" LCD_DEVICES="bayrad cfontz glk hd44780 lb216 lcdm001 mtxorb text" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php8-1" POSTGRES_TARGETS="postgres15" PYTHON_SINGLE_TARGET="python3_11" PYTHON_TARGETS="python3_11" QEMU_USER_TARGETS="x86_64" RUBY_TARGETS="ruby31" VIDEO_CARDS="amdgpu fbdev intel nouveau radeon radeonsi vesa dummy" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipp2p iface geoip fuzzy condition tarpit sysrq proto logmark ipmark dhcpmac delude chaos account"
Unset:  ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EMERGE_DEFAULT_OPTS, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LFLAGS, LIBTOOL, LINGUAS, MAKE, MAKEFLAGS, NM, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, PYTHONPATH, RANLIB, READELF, RUSTFLAGS, SIZE, STRINGS, STRIP, YACC, YFLAGS
Comment 1 Suvi Adams 2024-02-26 19:56:59 UTC 
Created attachment 886041 [details]
build.log
Comment 2 Suvi Adams 2024-02-26 19:58:41 UTC 
Created attachment 886046 [details, diff]
8ab1682e80a2b4185ee9ef66cbb44340245966fc backport
Comment 3 Larry the Git Cow gentoo-dev 2024-02-27 22:06:14 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e5746ec14d4a8dd7990f76d1cf2779d32108bb9f

commit e5746ec14d4a8dd7990f76d1cf2779d32108bb9f
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-02-27 21:48:04 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-02-27 21:51:16 +0000

    app-crypt/pinentry: backport include fix
    
    Revbump given both:
    a) implicit function declarations;
    b) Werner's comment on the upstream bug wrt possibility of it breaking
    some things with other pinentries.
    
    Closes: https://bugs.gentoo.org/925557
    Signed-off-by: Sam James <sam@gentoo.org>

 .../files/pinentry-1.2.1-include-memory.patch      | 313 +++++++++++++++++++++
 app-crypt/pinentry/pinentry-1.2.1-r6.ebuild        | 108 +++++++
 2 files changed, 421 insertions(+)