Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 924692

Summary: dev-games/aseprite-1.3.2 fails to compile: cfile.cpp:117:11: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
Product: Gentoo Linux Reporter: Agostino Sarubbo <ago>
Component: Current packagesAssignee: Azamat H. Hackimov <azamat.hackimov>
Status: RESOLVED FIXED    
Severity: normal CC: azamat.hackimov, eschwartz93, proxy-maint, sam
Priority: Normal Keywords: PullRequest
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://bugs.gentoo.org/show_bug.cgi?id=855305
https://github.com/gentoo/gentoo/pull/35619
https://github.com/aseprite/aseprite/issues/4413
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 618550    
Attachments: build.log

Description Agostino Sarubbo gentoo-dev 2024-02-16 08:26:58 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-games/aseprite-1.3.2 fails to compile.
Discovered on: amd64 (internal ref: lto_tinderbox)
System: LTO-SYSTEM (https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#LTO)

Info about the issue:
https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#CF0014
Comment 1 Agostino Sarubbo gentoo-dev 2024-02-16 08:26:59 UTC
Created attachment 885100 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2024-02-16 08:27:01 UTC
Error(s) that match a know pattern in addition to what has been reported in the summary:


FAILED: laf/base/CMakeFiles/laf-base.dir/cfile.cpp.o 
/var/tmp/portage/dev-games/aseprite-1.3.2/work/laf/base/cfile.cpp:117:11: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
Comment 3 Larry the Git Cow gentoo-dev 2024-04-11 21:34:39 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=95f26136eef6b81d752e4ddf102934306f69c581

commit 95f26136eef6b81d752e4ddf102934306f69c581
Author:     Eli Schwartz <eschwartz93@gmail.com>
AuthorDate: 2024-04-11 18:40:06 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-04-11 21:33:19 +0000

    dev-games/aseprite: mark as LTO-unsafe, strict-aliasing unsafe
    
    It has all the issues, and then throws in another issue with a bundled
    skia too just for kicks.
    
    Closes: https://bugs.gentoo.org/924692
    Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-games/aseprite/aseprite-1.2.40.ebuild | 15 ++++++++++++++-
 dev-games/aseprite/aseprite-1.3.2.ebuild  | 15 ++++++++++++++-
 2 files changed, 28 insertions(+), 2 deletions(-)
Comment 4 Azamat H. Hackimov 2024-04-14 18:04:08 UTC
Proposed solution is not actual fix.
Comment 5 Eli Schwartz 2024-04-14 18:23:35 UTC
The actual fix is a matter of upstream source code.

The Gentoo bug tracker tracks the process of making it safe to compile the package in Gentoo, and for that purpose, crippling the optimizer suffices and, crucially, means that for the purposes of a tracker bug, this package is no longer an open blocker, but a closed (resolved) blocker.
Comment 6 Azamat H. Hackimov 2024-04-15 09:14:38 UTC
As maintainer of package I decide how this issue should be threaten. I already proposed proper resolution in PR https://github.com/gentoo/gentoo/pull/35619.

Please get permission from the maintainer before making any changes to the package as stated in https://devmanual.gentoo.org/general-concepts/package-maintainers/index.html. I haven't received any requests regarding these changes.
Comment 7 Larry the Git Cow gentoo-dev 2024-04-16 14:18:25 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ca2ef8cf81daa4afafa3a052e8fba433f507c3cf

commit ca2ef8cf81daa4afafa3a052e8fba433f507c3cf
Author:     Azamat H. Hackimov <azamat.hackimov@gmail.com>
AuthorDate: 2024-03-04 13:43:00 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2024-04-16 14:18:23 +0000

    dev-games/aseprite: add 1.3.5
    
    Closes: https://bugs.gentoo.org/924692
    Signed-off-by: Azamat H. Hackimov <azamat.hackimov@gmail.com>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 dev-games/aseprite/Manifest                        |   1 +
 dev-games/aseprite/aseprite-1.3.5.ebuild           | 220 +++++++++++++++++++++
 .../files/aseprite-1.3.5_laf-strict-aliasing.patch | 155 +++++++++++++++
 3 files changed, 376 insertions(+)