Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 923998

Summary: sci-libs/openblas-0.3.26 installs files with broken symlink
Product: Gentoo Linux Reporter: Agostino Sarubbo <ago>
Component: Current packagesAssignee: Gentoo Science Related Packages <sci>
Status: RESOLVED FIXED    
Severity: normal CC: igor.s.krivenko, lumin, sam, ustinov, xiangluoming2015
Priority: Normal Keywords: PATCH
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://bugs.gentoo.org/show_bug.cgi?id=928506
https://bugs.gentoo.org/show_bug.cgi?id=928509
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: build.log.xz
eselect-ldso symlinks patch

Description Agostino Sarubbo gentoo-dev 2024-02-07 08:50:30 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sci-libs/openblas-0.3.26 installs files with broken symlink.
Discovered on: amd64 (internal ref: ci)

Info about the issue:
https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#QA0023
Comment 1 Agostino Sarubbo gentoo-dev 2024-02-07 08:50:33 UTC
Created attachment 884462 [details]
build.log.xz

build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)
Comment 2 xiaoming 2024-03-24 11:53:57 UTC
Seems it symlinks to wrong files in src_install since openblas-0.3.25:
	if use eselect-ldso; then
		insinto /usr/$(get_libdir)/blas/openblas/
		doins interface/libblas.so.3
		dosym -r /usr/$(get_libdir)/libblas.so.3 /usr/$(get_libdir)/blas/openblas/libblas.so
		doins interface/libcblas.so.3
		dosym -r /usr/$(get_libdir)/libcblas.so.3 /usr/$(get_libdir)/blas/openblas/libcblas.so

		insinto /usr/$(get_libdir)/lapack/openblas/
		doins interface/liblapack.so.3
		dosym -r /usr/$(get_libdir)/liblapack.so.3 /usr/$(get_libdir)/lapack/openblas/liblapack.so
		doins interface/liblapacke.so.3
		dosym -r /usr/$(get_libdir)/liblapacke.so.3 /usr/$(get_libdir)/lapack/openblas/liblapacke.so
	fi
/usr/$(get_libdir)/libblas.so* files belongs to sci-libs/lapack and shouldn't be symlinked by openblas.

As a comparison, in openblas-0.3.23 src_install:
	if use eselect-ldso; then
		insinto /usr/$(get_libdir)/blas/openblas/
		doins interface/libblas.so.3
		dosym libblas.so.3 usr/$(get_libdir)/blas/openblas/libblas.so
		doins interface/libcblas.so.3
		dosym libcblas.so.3 usr/$(get_libdir)/blas/openblas/libcblas.so

		insinto /usr/$(get_libdir)/lapack/openblas/
		doins interface/liblapack.so.3
		dosym liblapack.so.3 usr/$(get_libdir)/lapack/openblas/liblapack.so
		doins interface/liblapacke.so.3
		dosym liblapacke.so.3 usr/$(get_libdir)/lapack/openblas/liblapacke.so
	fi
Comment 3 Alexander B. Ustinov 2024-05-01 10:42:14 UTC
Created attachment 892073 [details, diff]
eselect-ldso symlinks patch

Attached patch works for me.
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-05-02 05:43:27 UTC
(In reply to Alexander B. Ustinov from comment #3)
> Created attachment 892073 [details, diff] [details, diff]
> eselect-ldso symlinks patch
> 
> Attached patch works for me.

Thanks!
Comment 5 Larry the Git Cow gentoo-dev 2024-05-02 05:44:01 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5f8d09e4b1e28f21aae673af7d7e660c217665d4

commit 5f8d09e4b1e28f21aae673af7d7e660c217665d4
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-05-02 05:43:27 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-05-02 05:43:27 +0000

    sci-libs/openblas: fix symlinks with USE=eselect-ldso
    
    Closes: https://bugs.gentoo.org/923998
    Signed-off-by: Sam James <sam@gentoo.org>

 sci-libs/openblas/openblas-0.3.26-r1.ebuild | 197 ++++++++++++++++++++++++++++
 1 file changed, 197 insertions(+)