| Summary: | app-portage/emerge-delta-webrsync-3.7.8 does not finish/hangs forever | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Jens <QCS4Gentoo> |
| Component: | Current packages | Assignee: | Portage team <dev-portage> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | QCS4Gentoo, zmedico |
| Priority: | Normal | Keywords: | InVCS |
| Version: | unspecified | ||
| Hardware: | AMD64 | ||
| OS: | Linux | ||
| See Also: | https://github.com/gentoo/portage/pull/1243 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
|
Description
Jens
2024-01-25 19:02:59 UTC
I feel like there's a missing `cd "${TMPDIR}"` where I removed `cd "${TMPDIR}/portage"` before the rsync call here, but I don't understand why we didn't notice earlier:
https://gitweb.gentoo.org/proj/portage.git/commit/?id=fa0f8720e168c95bcd6a8bd57d5abf09c488fd32
commit fa0f8720e168c95bcd6a8bd57d5abf09c488fd32
Author: Zac Medico <zmedico@gentoo.org>
Date: 2019-12-09 01:26:55 -0800
emerge-delta-webrsync: handle gentoo-YYYYMMDD directory name
Bug: https://bugs.gentoo.org/693454
Signed-off-by: Zac Medico <zmedico@gentoo.org>
I forgot to mention a nonstandard thing in my system: My /var/tmp/portage is a tmpfs mounted in the fstab: tmpfs /var/tmp/portage tmpfs defaults,size=20G 0 0 Likewise, my /tmp: tmpfs /tmp tmpfs defaults 0 0 The /var/tmp (PORTAGE_TMPDIR) is not in tmpfs though. Maybe this plays a role in the whole situation? I was able to reproduce the problem. The working directory of the rsync process is $DISTDIR, and it's syncing all of the $DISTDIR content instead of the intended repo content. The "missing" `cd "${TMPDIR}"` mentioned in comment #1 is truly missing and simply needs to be added back. It seems like this problem was not discovered earlier because rsync is only called when tarsync is not installed, and many users might have tarsync installed since there's a postinstall suggestion added in this emerge-delta-webrsync-3.7.3 ebuild commit:
https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2c594fce7f93b9a2f67ef26e722566f787fd4bde
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/proj/portage.git/commit/?id=86a3bfce1e399b3274143df00e68c762d3666724 commit 86a3bfce1e399b3274143df00e68c762d3666724 Author: Zac Medico <zmedico@gentoo.org> AuthorDate: 2024-01-29 00:48:53 +0000 Commit: Zac Medico <zmedico@gentoo.org> CommitDate: 2024-01-29 00:52:05 +0000 emerge-delta-webrsync: cd to TMPDIR before rsync The cd to TMPDIR before rsync was erroneously removed in commit fa0f8720e168c95bcd6a8bd57d5abf09c488fd32. Apparently this problem was not reported earlier because this code path only executes when tarsync is not installed, and the emerge-delta-webrsync postinstall suggests to install tarsync since version 3.7.3 released near the end of 2015. Bug: https://bugs.gentoo.org/922923 Fixes: fa0f8720e168 ("emerge-delta-webrsync: handle gentoo-YYYYMMDD directory name") Signed-off-by: Zac Medico <zmedico@gentoo.org> misc/emerge-delta-webrsync | 1 + 1 file changed, 1 insertion(+) Part of the reason this problem arose is divergence between emerge-webrsync and emerge-delta-webrsync. In emerge-webrsync there's an earlier `cd "${TMPDIR}"` added in this commit that never got merged to emerge-delta-webrsync because it actually had a -k option before emerge-webrsync:
https://gitweb.gentoo.org/proj/portage.git/commit/?id=644c0dd5daad47b6392d99c706afaea56e17ee31
commit 644c0dd5daad47b6392d99c706afaea56e17ee31
Author: Zac Medico <zmedico@gentoo.org>
Date: 2012-08-14 18:03:22 -0700
emerge-webrsync: add -k/--keep option
We can actually decouple this bug from bug 921380 since the problem is only in emerge-delta-webrsync, and that's installed by its own ebuild that we'll need to bump the version of. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f40bdffa6d120e8d699d95ed9f91706afb5a4373 commit f40bdffa6d120e8d699d95ed9f91706afb5a4373 Author: Zac Medico <zmedico@gentoo.org> AuthorDate: 2024-02-01 03:50:02 +0000 Commit: Zac Medico <zmedico@gentoo.org> CommitDate: 2024-02-01 03:50:08 +0000 app-portage/emerge-delta-webrsync: add 3.7.9 Closes: https://bugs.gentoo.org/922923 Signed-off-by: Zac Medico <zmedico@gentoo.org> app-portage/emerge-delta-webrsync/Manifest | 1 + .../emerge-delta-webrsync-3.7.9.ebuild | 45 ++++++++++++++++++++++ 2 files changed, 46 insertions(+) |
