Bug 922705

Summary:	dev-gap/edim-1.3.7 does not respect LDFLAGS (GCC-14-SYSTEM)
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Michael Orlitzky <mjo>
Status:	RESOLVED FIXED
Severity:	normal	CC:	frp.bissey, mjo, proxy-maint, sci-mathematics
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	https://github.com/gap-system/gap/issues/5601
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	331933
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2024-01-22 15:43:58 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-gap/edim-1.3.7 does not respect LDFLAGS (GCC-14-SYSTEM).
Discovered on: amd64 (internal ref: gcc14_tinderbox)

NOTE:
(GCC-14-SYSTEM) in the summary means that the bug was found on a machine that runs gcc-14 but this bug MAY or MAY NOT BE related to the new compiler
To reproduce this issue you may want to set LDFLAGS="${LDFLAGS} -Wl,--defsym=__gentoo_check_ldflags__=0". If this is not something about c/c++ context you may want to see this bug as an hint to hide the QA warning (with QA_FLAGS_IGNORED) where is not possible to respect LDFLAGS.

Comment 1 Agostino Sarubbo gentoo-dev

2024-01-22 15:44:00 UTC

Created attachment 882856 [details]
build.log

build log and emerge --info

Comment 2 Michael Orlitzky gentoo-dev

2024-01-22 17:16:04 UTC

This will probably be true of any package using gac to compile a GAP kernel module...

Comment 3 Michael Orlitzky gentoo-dev

2024-01-22 19:37:16 UTC

Will wait for advice from GAP before I do anything crazy.

Comment 4 François Bissey 2024-01-22 20:06:54 UTC

It would not be complicated to make gac respect flags, but yes let's hear from upstream first.

From gac
# read sysinfo.gap, which sets GAP_CFLAGS, GAP_CPPFLAGS, etc.
. "/usr/lib64/gap/sysinfo.gap"

# Extract sysinfo settings...
gap_compiler="${GAP}"
c_compiler="${GAP_CC}"
cxx_compiler="${GAP_CXX}"
c_dyn_linker="${GAP_CC}"
c_addlibs=""

GAP_CFLAGS="${GAP_CFLAGS} ${GAC_CFLAGS}"
GAP_CXXFLAGS="${GAP_CXXFLAGS} ${GAC_CFLAGS}"
GAP_LDFLAGS="${GAP_LDFLAGS} ${GAC_LDFLAGS}"

So, just defining some GAC_*FLAGS may fix the issue.

Comment 5 Larry the Git Cow gentoo-dev

2024-01-23 01:31:16 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=68585b45441f0dab9c77d0210e5baf523de74436

commit 68585b45441f0dab9c77d0210e5baf523de74436
Author:     Michael Orlitzky <mjo@gentoo.org>
AuthorDate: 2024-01-23 01:22:54 +0000
Commit:     Michael Orlitzky <mjo@gentoo.org>
CommitDate: 2024-01-23 01:29:34 +0000

    dev-gap/edim: patch to support user *FLAGS
    
    Upstream suggested we fix this in EDIM, so:
    
      https://github.com/frankluebeck/EDIM/pull/23
    
    Closes: https://bugs.gentoo.org/922705
    Signed-off-by: Michael Orlitzky <mjo@gentoo.org>

 .../{edim-1.3.7.ebuild => edim-1.3.7-r1.ebuild}    |  4 +++
 dev-gap/edim/files/edim-1.3.7-user-flags.patch     | 29 ++++++++++++++++++++++
 2 files changed, 33 insertions(+)