Bug 922613

Summary:	net-libs/libndp-1.8 - .../libndp.c: In function 'mysendto6': /var/tmp/portage/net-libs/libndp-1.8/work/libndp-1.8/libndp/libndp.c:212:50: error: passing argument 5 of 'sendto' from incompatible pointer type [-Wincompatible-pointer-types]
Product:	Gentoo Linux	Reporter:	ernsteiswuerfel <erhard_f>
Component:	Current packages	Assignee:	Gentoo Linux Gnome Desktop Team <gnome>
Status:	RESOLVED FIXED
Severity:	normal	CC:	erhard_f
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	https://github.com/jpirko/libndp/issues/25
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	870412, 941869
Attachments:	build.log emerge --info libndp (ppc64, 1.9)

Description ernsteiswuerfel archtester

2024-01-21 12:16:44 UTC

Created attachment 882763 [details]
build.log

[...]
libtool: compile:  powerpc-gentoo-linux-musl-gcc "-DPACKAGE_NAME=\"libndp\"" "-DPACKAGE_TARNAME=\"libndp\"" "-DPACKAGE_VERSION=\"1.8\"" "-DPACKAGE_STRING=\"libndp 1.8\"" "-DPACKAGE_BUGREPORT=\"jiri@resnulli.us\"" "-DPACKAGE_URL=\"\"" "-DPACKAGE=\"libndp\"" "-DVERSION=\"1.8\"" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 "-DLT_OBJDIR=\".libs/\"" -DHAVE_STDINT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STDLIB_H=1 -DHAVE_MALLOC=1 -DENABLE_LOGGING=1 -I. -I/var/tmp/portage/net-libs/libndp-1.8/work/libndp-1.8/libndp -fvisibility=hidden -ffunction-sections -fdata-sections -I/var/tmp/portage/net-libs/libndp-1.8/work/libndp-1.8/include -D_GNU_SOURCE -Os -mcpu=7450 -mtune=7450 -pipe -Wall -c /var/tmp/portage/net-libs/libndp-1.8/work/libndp-1.8/libndp/libndp.c  -fPIC -DPIC -o .libs/libndp_la-libndp.o
/var/tmp/portage/net-libs/libndp-1.8/work/libndp-1.8/libndp/libndp.c: In function 'mysendto6':
/var/tmp/portage/net-libs/libndp-1.8/work/libndp-1.8/libndp/libndp.c:212:50: error: passing argument 5 of 'sendto' from incompatible pointer type [-Wincompatible-pointer-types]
  212 |         ret = sendto(sockfd, buf, buflen, flags, &sin6, sizeof(sin6));
      |                                                  ^~~~~
      |                                                  |
      |                                                  struct sockaddr_in6 *
In file included from /var/tmp/portage/net-libs/libndp-1.8/work/libndp-1.8/libndp/libndp.c:27:
/usr/include/sys/socket.h:396:49: note: expected 'const struct sockaddr *' but argument is of type 'struct sockaddr_in6 *'
  396 | ssize_t sendto (int, const void *, size_t, int, const struct sockaddr *, socklen_t);
      |                                                 ^~~~~~~~~~~~~~~~~~~~~~~
make[1]: *** [Makefile:455: libndp_la-libndp.lo] Error 1
make[1]: Leaving directory '/var/tmp/portage/net-libs/libndp-1.8/work/libndp-1.8-.ppc/libndp'
make: *** [Makefile:388: all-recursive] Error 1

Comment 1 ernsteiswuerfel archtester

2024-01-21 12:17:38 UTC

Created attachment 882764 [details]
emerge --info

Comment 2 ernsteiswuerfel archtester

2024-06-18 22:49:56 UTC

Upstream fix (not merged yet): https://github.com/jpirko/libndp/pull/28/commits/dfd70608a6a2ea164b18e7874de58ef6fd781cef

Comment 3 Larry the Git Cow gentoo-dev

2024-11-08 20:19:52 UTC

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ac53a65fdd59d972b66d26ff9e90295c4300482a

commit ac53a65fdd59d972b66d26ff9e90295c4300482a
Author:     Pacho Ramos <pacho@gentoo.org>
AuthorDate: 2024-11-08 19:52:53 +0000
Commit:     Pacho Ramos <pacho@gentoo.org>
CommitDate: 2024-11-08 19:55:21 +0000

    net-libs/libndp: add 1.9
    
    Closes: https://bugs.gentoo.org/940183
    Bug: https://bugs.gentoo.org/922613
    Signed-off-by: Pacho Ramos <pacho@gentoo.org>

 net-libs/libndp/Manifest          |  1 +
 net-libs/libndp/libndp-1.9.ebuild | 25 +++++++++++++++++++++++++
 2 files changed, 26 insertions(+)

Comment 4 ernsteiswuerfel archtester

2024-11-10 01:30:05 UTC

Created attachment 908346 [details]
libndp (ppc64, 1.9)

Upstream patch https://github.com/jpirko/libndp/pull/28/commits/dfd70608a6a2ea164b18e7874de58ef6fd781cef is still needed. Seems it did not find its' way into 1.9.

Comment 5 Larry the Git Cow gentoo-dev

2024-11-11 10:28:16 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5ef6e9bd3a715ac1248e2038bb02cf989e510b6a

commit 5ef6e9bd3a715ac1248e2038bb02cf989e510b6a
Author:     Pacho Ramos <pacho@gentoo.org>
AuthorDate: 2024-11-11 10:27:10 +0000
Commit:     Pacho Ramos <pacho@gentoo.org>
CommitDate: 2024-11-11 10:27:58 +0000

    net-libs/libndp: Fix building with gcc 14
    
    Thanks-to: ernsteiswuerfel
    Closes: https://bugs.gentoo.org/922613
    Signed-off-by: Pacho Ramos <pacho@gentoo.org>

 net-libs/libndp/files/libndp-1.9-gcc14.patch | 63 ++++++++++++++++++++++++++++
 net-libs/libndp/libndp-1.9-r1.ebuild         | 30 +++++++++++++
 2 files changed, 93 insertions(+)